Add change type signature test suite #2760
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h/haskell-language-server into add-change-type-test-suite-no-921
|
@pepeiborra I dropped the other PR as it turns out 9.2.1 changed the structure of error messages. As a result I've removed the plugin from 9.2.1 but integrated the test suite |
|
Would you like to merge this while you're still working on the other PR? |
michaelpj
approved these changes
Mar 7, 2022
michaelpj
reviewed
Mar 7, 2022
| @@ -305,7 +305,7 @@ common selectionRange | |||
| cpp-options: -DselectionRange | |||
|
|
|||
| common changeTypeSignature | |||
| if flag(changeTypeSignature) | |||
| if flag(changeTypeSignature) && impl(ghc < 9.2.1) | |||
There was a problem hiding this comment.
Actually, this should probably be ghc < 9.2 otherwise it will allow 9.2!
The test suite is now fixed, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #2749.
Also disables the plugin for 9.2.1 as the test suite isn't passing (despite the functionality working)