Documentation: Imrpove "Contributing" (and amend Sphinx builders) #4494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains opinionated changes, please check!
I was compiling the documentation using
nix build .#docs
. Two observations:sphinx-build
command than the one used indocs/Makefile
.So I fixed the warnings (duplicate IDs etc.) and thought, why not use the Makefile to build the documentation also with Nix?
However, that was not easily possible because the Makefile passed on all arguments (i.e., even arguments to the
make
command itself) tosphinx-build
. (I think that is/was actually a bug.)Anyways, I ended up changing the Makefile in ways that you may not agree with. In particular,
sphinx-build
invocation (warnings are errors).help
target which seemed a bit unnecessary and overcomplicates things.html
target to build the documentaiton using the HTML builder.Have a look and let me know what you think!