Enable bench for 9.10 #4512
Merged
Enable bench for 9.10 #4512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
soulomoon
commented
Mar 6, 2025
•
soulomoon
commented
- Fix the dependency problem preventing 9.10 from building bench
- Enable the bench to build even not for performance label, still need performance label if we need to run it.
- bump up to actions/checkout-v4 in bench
… add source repository
|
@soulomoon Since hp2pretty seems to be unmaintained, I am wondering whether it would make sense to migrate our benchmarks to eventlog2html. I am unfamiliar with the benchmarks, though, so maybe there is a good reason it is done like this. I suspect that the benchmark suite is rather old, and we could move some of the infrastructure to maintained alternatives. |
soulomoon
added
the
performance
fendor
approved these changes
Mar 8, 2025
| @@ -17,7 +17,6 @@ on: | |||
| jobs: | |||
| pre_job: | |||
| runs-on: ubuntu-latest | |||
| if: contains(github.event.pull_request.labels.*.name, 'performance') | |||
There was a problem hiding this comment.
Needs to be readded, right?
There was a problem hiding this comment.
I move it down to the run session, so if performance label is provided, we build and run the bench, if not, we only build the bench.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.