Local binding hints (WIP) #4610
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: fendor <[email protected]>
Now let and where clause will show binding type in inlay hints
cassandracomar
force-pushed
the
local-binding-hints
branch
from
4c79cba to
5eae7ca
Compare
…to local-binding-hints
cassandracomar
force-pushed
the
local-binding-hints
branch
from
5eae7ca to
9cde704
Compare
cassandracomar
force-pushed
the
local-binding-hints
branch
from
eede0e7 to
84673ac
Compare
cassandracomar
commented
Jun 3, 2025
| properties = emptyProperties | ||
| & defineEnumProperty #mode "Control how type lenses are shown" | ||
| [ (Always, "Always displays type lenses of global bindings") | ||
| , (Exported, "Only display type lenses of exported global bindings") | ||
| , (Diagnostics, "Follows error messages produced by GHC about missing signatures") | ||
| ] Always | ||
| & defineBooleanProperty #localBindingInlayHintOn | ||
| "Display inlay hints of local bindings" |
There was a problem hiding this comment.
this needs a better explanation for documentation
There was a problem hiding this comment.
this may also be clearer as a three-way enum called localBindingHintsMode with the options NoLocalHints, UseInlayHints, UseCodeLenses.
happy to let others bikeshed this, though.
cassandracomar
force-pushed
the
local-binding-hints
branch
from
84673ac to
a2759f6
Compare
cassandracomar
commented
Jun 3, 2025
| "mode": "always" | ||
| }, | ||
| "globalOn": true | ||
| "inlayHintsOn": true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation of #4368.
so far, I've merged in changes in master and updated things so they compile with ghc-9.12.
TODO:
update: this now allows either code lenses or inlay hints for local bindings. as we discussed, I've defaulted this to code lenses, with an optional toggle to flip on inlay hints instead. but the code lenses don't have their tests restored as yet. will reintroduce those tomorrow.