Conversation
Co-authored-by: fendor <fendor@users.noreply.github.com>
Now let and where clause will show binding type in inlay hints
cassandracomar
force-pushed
the
local-binding-hints
branch
from
4c79cba to
5eae7ca
Compare
…to local-binding-hints
cassandracomar
force-pushed
the
local-binding-hints
branch
from
5eae7ca to
9cde704
Compare
cassandracomar
force-pushed
the
local-binding-hints
branch
from
eede0e7 to
84673ac
Compare
| , (Diagnostics, "Follows error messages produced by GHC about missing signatures") | ||
| ] Always | ||
| & defineBooleanProperty #localBindingInlayHintOn | ||
| "Display inlay hints of local bindings" |
There was a problem hiding this comment.
this needs a better explanation for documentation
There was a problem hiding this comment.
this may also be clearer as a three-way enum called localBindingHintsMode with the options NoLocalHints, UseInlayHints, UseCodeLenses.
happy to let others bikeshed this, though.
There was a problem hiding this comment.
Yeah, sounds good, although I'm somewhat tempted towards a global option for the user preference here.
cassandracomar
force-pushed
the
local-binding-hints
branch
from
84673ac to
a2759f6
Compare
| "mode": "always" | ||
| }, | ||
| "globalOn": true | ||
| "inlayHintsOn": true |
|
I wonder what to do about inlay hints vs code lenses. As I commented in the other issue, I do think we should prefer them if we can. But maybe we need a consistent approach. e.g. something like:
Out of scope for this PR though. |
|
Give a shout if you need help/want attention on any bit of it in particular! |
will do! haven't had a chance to go through the test failures. |
5 participants
continuation of #4368.
so far, I've merged in changes in master and updated things so they compile with ghc-9.12.
TODO:
update: this now allows either code lenses or inlay hints for local bindings. as we discussed, I've defaulted this to code lenses, with an optional toggle to flip on inlay hints instead. but the code lenses don't have their tests restored as yet. will reintroduce those tomorrow.