4416 - show versions of installed packages #4651
Draft
batkot wants to merge 19 commits intohaskell:masterfrom
Draft
4416 - show versions of installed packages #4651batkot wants to merge 19 commits intohaskell:masterfrom
batkot wants to merge 19 commits intohaskell:masterfrom
Conversation
Collaborator
|
Personally I'd be somewhat inclined to do this in a hover rather than an inlay hint, but debatable. |
Collaborator
|
Not sure what a coherent argument would look like, but I would argue something like:
|
Contributor
Author
|
I added installed package version info to dependency hover and adjusted documentation link to point to the right version as well: Screen.Recording.2025-08-10.at.22.50.48.movFair points and in principle I share your views on inlays. However I still like their look and feel for package versions. You immediately get a list of what's exactly installed. It didn't feel like cluttering the UI, since there's not a lot of LSP related info in Anyway, I'm not married to the idea, so I can as well just drop it (inlays/code lenses) 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Took my chances on implementing @fendor suggestions from @lucalabs-de #4430 MR.
Inlay Hints

CodeLenses got hard to read when there are multiple packages in single line, so I added package name then to make it easier to understand.

As noticed in previous MR, because of limited positioning options lenses can look a bit wonky depending on cabal file formatting. Hover could be a nice (and easy to add) fallback as well, but I'm not sure about status of hover ticket (#4417) and for now I just decided to avoid unnecessary conflicts.
Closes #4416 (based on #4430)