Use edit-distance to fix typos in cabal fields #4722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bodigrim
reviewed
Sep 5, 2025
crtschin
force-pushed
the
crtschin/codeaction-cabal-fix-typos
branch
from
3c4d9d8 to
53bf792
Compare
fendor
approved these changes
Sep 11, 2025
|
|
||
| library | ||
| qqjfault-lang: Haskell2010 | ||
| -- Import isn't supported right now. |
fendor
reviewed
Sep 11, 2025
| @@ -18,6 +18,8 @@ import Prelude hiding (filter) | |||
| data Scored a = Scored {score :: !Int, original:: !a} | |||
| deriving (Functor, Show) | |||
|
|
|||
| newtype Matcher a = Matcher { runMatcher :: T.Text -> [T.Text] -> [Scored a] } | |||
There was a problem hiding this comment.
Perhaps a comment would not hurt for why we have this :)
Perhaps all fuzzy filters should return this interface? As is, this type is only used in the cabal-plugin, right?
There was a problem hiding this comment.
Perhaps a comment would not hurt for why we have this :)
Will do.
Perhaps all fuzzy filters should return this interface? As is, this type is only used in the cabal-plugin, right?
Interesting thought. It currently is indeed yes. I'll try changing the fuzzy functions to have it and check if it's better, otherwise I'll move it to the cabal-plugin, as I just added it to not have a bare function type in CompleterData.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4357.
This adds a pretty simple function for calculating the edit distance between two strings and uses it to score suggestions in completion lists. Some
Matcherthat's used in scoring texts intoCompleterData. Couldn't really massage that into theweightedConstantCompleterthat's used for licenses.