Skip to content

Conversation

dschrempf
Copy link
Collaborator

@dschrempf dschrempf commented Sep 12, 2025

This PR contains some girl-scout changes as well as changes to how the eval plugin treats stdout and stderr.

Eval plugin

We now capture output to stdout and stderr induced as a possible side effect by the statement being evaluated. This is fragile because the output may be scrambled in a concurrent setting when HLS is writing to one of these file handles from a different thread.

Fixes #1977, most likely also #4390 (although this is debatable, we could do something more sophisticated).

-- >>> putStrLn "Hello"
-- Hello

-- >>> hPutStrLn stderr "Hello"
-- Hello

-- >>> putStrLn "Hello," >> pure "World!"
-- Hello,
-- "World!"

Girl scout changes

  • Docs: Fix some links in eval plugin in-source documentation
  • Clarify documentation of expected test failure
  • Update Nix Flake (Darwin issues seem to be solved)
  • Update some tests and avoid mentioning GHC 9.2
  • Remove comment referring to GHC 9.2 and fix code

@dschrempf dschrempf marked this pull request as draft September 12, 2025 15:20
@dschrempf dschrempf changed the title Minima girls scout changes removing code referring to deprecated GHC versions Remove code referring to GHC versions not anymore supported by HLS Sep 12, 2025
@dschrempf dschrempf force-pushed the dom/girl-scout branch 2 times, most recently from 199c13f to 6d59fcd Compare September 13, 2025 08:42
@dschrempf dschrempf changed the title Remove code referring to GHC versions not anymore supported by HLS Some girls scout changes related to GHC versions not anymore supported by HLS Sep 14, 2025
@dschrempf dschrempf marked this pull request as ready for review September 14, 2025 14:38
@dschrempf dschrempf changed the title Some girls scout changes related to GHC versions not anymore supported by HLS Capture output of eval plugin and some girls scout changes Sep 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capture stdout and stderr in eval plugin
1 participant