Fix Signature Help inside do Notation in GHC >= 9.10#4904
Open
vidit-od wants to merge 4 commits intohaskell:masterfrom
Open
Fix Signature Help inside do Notation in GHC >= 9.10#4904vidit-od wants to merge 4 commits intohaskell:masterfrom
do Notation in GHC >= 9.10#4904vidit-od wants to merge 4 commits intohaskell:masterfrom
Conversation
Some nodes have there type info stored in nodes generated by ghc. In case no type info found in source node, fall back to traversing ghc generated nodes for types Signed-off-by: vidit-od <vidit894@gmail.com>
vidit-od
changed the title
do Notation
jian-lin
requested changes
Apr 19, 2026
Collaborator
jian-lin
left a comment
jian-lin
left a comment
There was a problem hiding this comment.
Looks good. I'll do a more careful review later.
In the meantime, it would be good to add a test case for the issue.
Signed-off-by: vidit-od <vidit894@gmail.com>
fendor
reviewed
Apr 30, 2026
Collaborator
|
@jian-lin I think this is ready for a review now |
vidit-od
commented
Apr 30, 2026
jian-lin
requested changes
Apr 30, 2026
jian-lin
changed the title
do Notation do Notation in GHC >= 9.10
Signed-off-by: vidit-od <vidit894@gmail.com>
vidit-od
force-pushed
the
Do-Signature-Traversal
branch
from
c891a41 to
9344a71
Compare
vidit-od
force-pushed
the
Do-Signature-Traversal
branch
from
6c39a93 to
20e9d05
Compare
If source -> identifier info -> details == Nothing, then we fallback to generated by ghc node and explore generated by ghc -> identifier info -> details Signed-off-by: vidit-od <vidit894@gmail.com>
vidit-od
commented
May 1, 2026
Comment on lines
+300
to
+303
| let mTypeOfName = identType identifierDetails <|> do | ||
| nodeInfo <- generatedNodeInfo hieAst | ||
| details <- M.lookup identifier (nodeIdentifiers nodeInfo) | ||
| identType details |
Collaborator
Author
There was a problem hiding this comment.
@jian-lin This should take care of lookup to generated nodes on fallback for identifier details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes : #4769
As recommended, Type information of Some nodes were stored in GHC generated nodes.
This PR keeps the old pipeline and add a Fall back to traverse these generated nodes in case source node lack type information.
Attached image of signature help in cases where we did not get them before;
Prerequisite :
Major Finding credits : @jian-lin