Skip to content

Fix and enable disabled code action unit tests, fix fallback handler #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 3, 2020
Merged

Fix and enable disabled code action unit tests, fix fallback handler #643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
030bf48
Fixup documentation of hlsCommand.
peterwicksstringfield Nov 27, 2020
5c2cab6
Fix implementation of fallback handler for code action literals.
peterwicksstringfield Dec 1, 2020
bb1e22b
Enable and fix disabled unit tests for code actions.
peterwicksstringfield Dec 1, 2020
3db418e
Increase robustness of tests by skipping extraneous messages.
peterwicksstringfield Dec 1, 2020
8efc4e8
Comment in and disable test for prefixing unused names with "_".
peterwicksstringfield Dec 1, 2020
e9638a5
Add hie.yaml files in testdata to help CI run.
peterwicksstringfield Dec 2, 2020
4c9de9e
In tests, filter out diagnostics from other files.
peterwicksstringfield Dec 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions hls-plugin-api/src/Ide/Plugin.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,9 +238,8 @@ makeExecuteCommands ecs lf ide = wrapUnhandledExceptions $ do
-- Send off the workspace request if it has one
forM_ mEdit $ \edit -> do
let eParams = J.ApplyWorkspaceEditParams edit
-- TODO: Use lspfuncs to send an applyedit message. Or change
-- the API to allow a list of messages to be returned.
return (Right J.Null, Just(J.WorkspaceApplyEdit, eParams))
reqId <- LSP.getNextReqId lf
LSP.sendFunc lf $ ReqApplyWorkspaceEdit $ RequestMessage "2.0" reqId WorkspaceApplyEdit eParams

case mCmd of
-- If we have a command, continue to execute it
Expand Down
Loading