Skip to content

Regenerate .travis.yml #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

phadej
Copy link

@phadej phadej commented Dec 9, 2017

@phadej
Copy link
Author

phadej commented Dec 10, 2017

I'll do the buildinfo trick @hvr mentioned (See unix package), and incorporate #245 here.

@kazu-yamamoto
Copy link
Collaborator

I don't understand why Travis CI is still failing...

@phadej
Copy link
Author

phadej commented Dec 11, 2017

the doctest suite doesn' work with new-build, things are in different places

@eborden
Copy link
Collaborator

eborden commented Dec 11, 2017

There were some questions the last time this PR came around. Is new-build now the official and documented way to run cabal or is it still experimental?

Also my concerns about utilizing cabal-install-head still remain.

#254

@eborden eborden added the WIP label Dec 11, 2017
@kazu-yamamoto
Copy link
Collaborator

kazu-yamamoto commented Dec 13, 2017

@eborden The new features of cabal are used on Travis CI only. We can use any build tools locally as we like. So, I think we don't have to worry too much.

@kazu-yamamoto
Copy link
Collaborator

@phadej Please incorporate #245 and comment out the doctest.

@kazu-yamamoto
Copy link
Collaborator

If people agree, I will merge #245 to record @hvr's credit.
@phadej Then, you should rebase this PR onto master.

@phadej
Copy link
Author

phadej commented Dec 13, 2017

@kazu-yamamoto #245 or #254 ? :)

@phadej
Copy link
Author

phadej commented Dec 13, 2017

@kazu-yamamoto but please merge @hvr's #254, I haven't noticed he already did buildinfo.in trick! That's great. (We discussed that approach, and @hvr didn't even remember he already made a patch!)

@kazu-yamamoto
Copy link
Collaborator

Ah. I meant #254!

@kazu-yamamoto
Copy link
Collaborator

@eborden Do you agree with merging #254 (and #259 on the top of #254)?

@vincenthz
Copy link

@kazu-yamamoto I don't think it change the fact that new-build is not the default way to build for any stack user and cabal user < ghc 8.2 (and cabal user on 8.2 not yet using the non default new-build).
A pragmatic travis script at this stage would not remove the most currently used build path and would test cabal build and cabal new-build, not just new-build.

@eborden
Copy link
Collaborator

eborden commented Dec 13, 2017

I don't have any major complaints about using new-build. I think @vincenthz's stance is reasonable. My only real concern is building utilizing cabal-install-head. network's CI is meant to ensure that network builds for most users of the package. Most users of the package are not going to be using cabal-install-head. I'm fine with adding a matrix point to utilize head the same way we do with GHC, but that matrix point should be allowed to fail.

@kazu-yamamoto
Copy link
Collaborator

@phadej I created the travis branch. I cannot guarantee that this branch will be merged but you can modify .travis.yml as you like on top of this branch.

To merge this branch to master, we should add cabal build in addition to the current cabal new-build. I don't know how to implement this.

@eborden
Copy link
Collaborator

eborden commented Dec 14, 2017

@phadej any objection to changing cabal-install-head to cabal-install-2.0? It would be lovely if @hvr could add a cabal-install-stable to the ppa collection that tracks releases and to prevent having change this script with every release.

@kazu-yamamoto
Copy link
Collaborator

travis now supports 6 versions of GHC and CI works very well.
I need this feature to tackle other issues.
Actually, the build system detects mkWeakMVar is missing in GHC 7.4.
So, I will merge travis to master anyway and open a new issue to describe our concerns and todo list.

@kazu-yamamoto kazu-yamamoto mentioned this pull request Dec 15, 2017
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants