Skip to content

use environments to lazily initialize benchmarks #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2019
Merged

Conversation

kuk0
Copy link
Contributor

@kuk0 kuk0 commented Oct 29, 2017

if we only need to run a few benchmarks,
e.g. text-benchmarks Pure/drop/Text+tiny
it's wasteful to initialize all of them
(and read all the test data in memory - all
the test data is a few hundreds of MB, but
we read it in several tests, as different types,
and most seriously, as String - which turns this
into GBs of memory)

@kuk0
Copy link
Contributor Author

kuk0 commented Oct 29, 2017

in fact, i would like to either split or completely delete the Strings from the benchmarks; just reading 100MB of text as a String is slow and i'm not really convinced the String benchmarks are useful

if we only need to run a few benchmarks,
e.g. `text-benchmarks Pure/drop/Text+tiny`
it's wasteful to initialize all of them
(and read all the test data in memory - all
the test data is a few hundreds of MB, but
we read it in several tests, as different types,
and most seriously, as String - which turns this
into GBs of memory)
@hvr hvr merged commit 8d1dd94 into haskell:master Jun 23, 2019
@hvr
Copy link
Member

hvr commented Jun 23, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants