Skip to content

Show docs as docs, not as sources on Windows too #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

DunetsNM
Copy link
Contributor

@DunetsNM DunetsNM commented Aug 5, 2020

Normalize slashes in file URLs to correctly show docs on Windows.

Compliments /pull/21

Before:

image

After:

image

There's also related bug on HLS end haskell/haskell-language-server/issues/247 (trivial to fix, will submit soon)

Or do you think it's better to normalize slashes in all paths on HLS end? I'm not sure how easy it is to pinpoint all paths' origins there, also other plugins are potentially affected (ghcide, hie).

@lukel97
Copy link
Collaborator

lukel97 commented Aug 5, 2020

Do you think you could fix this upstream in ghcide? That way it would also fix the issue across the other language clients, I think the relative lines are here
https://github.com/digital-asset/ghcide/blob/765967d19be4ca64abc999173029a6bfe6aec113/src/Development/IDE/Spans/Documentation.hs#L69-L70

@DunetsNM
Copy link
Contributor Author

DunetsNM commented Aug 5, 2020

Sure, just opened a pr there for the third slash, can replace backslashes too

@lukel97
Copy link
Collaborator

lukel97 commented Aug 5, 2020

@DunetsNM thanks! I won't be able to merge that PR into digital-asset/ghcide but we can cherry-pick it onto the HLS submodule at some point. Is haskell/ghcide#721 enough on its own or does this PR also need merged to fix it?

@DunetsNM
Copy link
Contributor Author

DunetsNM commented Aug 5, 2020

@bubba yes haskell/ghcide/pull/721 should be enough on its own 👍
Just tried v1.0.1 with local ghcide fix and it works fine, so this pr can be abandoned

@DunetsNM DunetsNM closed this Aug 5, 2020
@DunetsNM DunetsNM deleted the fix-windows-doc-path branch September 4, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants