Skip to content

Add integration smoke test #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Oct 9, 2021
Merged

Add integration smoke test #481

merged 14 commits into from
Oct 9, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Oct 8, 2021

  • Tests are gonna checking that:

    • The server executables (wrapper and server itself) are downloaded
    • The hls server is started
  • It uses for checking the presence of the executable files in a test path so it is adding a new option to configure where the executables are downloaded: haskell.releasesDownloadStoragePath. I think the option is useful in its own and could help to alliviate Cleanup executables from old releases #273 cause the user can point to a known directory and remove the desired obsolete versions

  • It sets the log file path to check the hls server has started and has begun to write in that log

    • It has the caveat the test depends on trace.server being effective but it would fail it it does not work correctly. The only way to mask would be write the log without start the server on purpose. I hope it will not happen but we could check the content of the file to be more confident.

Closes #473

@jneira jneira requested review from lukel97 and berberman October 8, 2021 09:30
@jneira
Copy link
Member Author

jneira commented Oct 8, 2021

@jneira
Copy link
Member Author

jneira commented Oct 8, 2021

I can see in this pr macos log:


Unable to create basic Accelerated OpenGL renderer.

Unable to create basic Accelerated OpenGL renderer.
Core Image is now using the software OpenGL renderer. This will be slow.

That is nos present in my builds

@jneira
Copy link
Member Author

jneira commented Oct 8, 2021

I am seeing this warning in the pr jobs:


.github/workflows/test.yml : .github#L1
macOS-latest workflows will use macOS-11 soon. For more details, see https://github.com/actions/virtual-environments/issues/4060

And it is not present in my repo neither

@jneira
Copy link
Member Author

jneira commented Oct 8, 2021

Force it to use macos-11 fixed the issue indeed 🎉
We can switch to latest when all images use it (it involves changing required checks)

Copy link
Collaborator

@berberman berberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a super nice test suite! 🎉

@jneira jneira merged commit 2020488 into haskell:master Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a test suite and setup ci to run them
2 participants