-
Notifications
You must be signed in to change notification settings - Fork 90
Add integration smoke test #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The macos test is working in my branch: https://github.com/jneira/vscode-haskell/runs/3837042550?check_suite_focus=true |
I can see in this pr macos log:
That is nos present in my builds |
I am seeing this warning in the pr jobs:
And it is not present in my repo neither |
Force it to use macos-11 fixed the issue indeed 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a super nice test suite! 🎉
Tests are gonna checking that:
It uses for checking the presence of the executable files in a test path so it is adding a new option to configure where the executables are downloaded:
haskell.releasesDownloadStoragePath
. I think the option is useful in its own and could help to alliviate Cleanup executables from old releases #273 cause the user can point to a known directory and remove the desired obsolete versionsIt sets the log file path to check the hls server has started and has begun to write in that log
trace.server
being effective but it would fail it it does not work correctly. The only way to mask would be write the log without start the server on purpose. I hope it will not happen but we could check the content of the file to be more confident.Closes #473