Skip to content

Fix hole_severity option: Use integer instead of string #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2021
Merged

Fix hole_severity option: Use integer instead of string #511

merged 1 commit into from
Nov 30, 2021

Conversation

@mirko-plowtech
Copy link
Contributor

@mirko-plowtech mirko-plowtech commented Nov 30, 2021

Related issue: #502

@mirko-plowtech mirko-plowtech mentioned this pull request Nov 30, 2021
Closed
jneira
jneira reviewed Nov 30, 2021
View reviewed changes
package.json
4,
null
],
"default": null,
Copy link
Member

@jneira jneira Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess we cant get rid of null

jneira
jneira approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, many thanks for the fix

@jneira jneira merged commit 43d6e27 into haskell:master Nov 30, 2021
@jneira jneira linked an issue Nov 30, 2021 that may be closed by this pull request
Wingman/tactics "hole_severity" option is broken #502
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jneira jneira jneira approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wingman/tactics "hole_severity" option is broken

2 participants

@mirko-plowtech @jneira