Manage all the Haskell things #547
Conversation
Please enter the commit message for your changes. Lines starting
|
I started an alpha release pipeline: https://gitlab.haskell.org/haskell/ghcup-hs/-/pipelines/49115 Once the binaries are built there, we can manually test. |
hasufell
force-pushed
the
issue-540
branch
3 times, most recently
from
3db3e2b to
b2917ec
Compare
|
Windows failures are due to MAX_PATH issues with symlinks... that'll requires another bugfix in ghcup. |
hasufell
force-pushed
the
issue-540
branch
2 times, most recently
from
c68ceed to
f8970d8
Compare
|
All set! From my side, this can be merged. |
|
I'm also trying to fix the PATH issues btw... so hold on |
src/utils.ts
Outdated
| export function resolvePATHPlaceHolders(path: string, folder?: WorkspaceFolder) { | ||
| return path | ||
| .replace('${HOME}', os.homedir) | ||
| .replace('${home}', os.homedir) | ||
| .replace('$PATH', process.env.PATH!) | ||
| .replace('${PATH}', process.env.PATH!); | ||
| } |
There was a problem hiding this comment.
Why is this new? According to the docs, this should have worked already, or is this for better error messages?
There was a problem hiding this comment.
I don't understand your question. resolvePATHPlaceHolders is not the same as resolvePathPlaceHolders.
There was a problem hiding this comment.
I did not even consciously notice that there are two functions with an almost identical name...
Why are there two very similar functions, and this one has an unused parameter?
There was a problem hiding this comment.
Why are there two very similar functions, and this one has an unused parameter?
Because this function replaces PATH, which is not a generic path variable, so they do different things.
There was a problem hiding this comment.
Maybe we don't even need it at all and can pass it unchanged. I haven't tested.
There was a problem hiding this comment.
How do we test whether we need it?
|
Is there anything left? |
Only one more review run |
fendor
left a comment
fendor
left a comment
There was a problem hiding this comment.
LGTM, let's get it merged!
3 participants
This will most likely fail in CI, because of https://gitlab.haskell.org/haskell/ghcup-hs/-/commit/0c70feb09c54bf06ee9ceddfaf808b2ca1027688