Skip to content

Fix the environment used during deploy#269

Merged
frenck merged 1 commit into
hassio-addons:mainfrom
wbyoung:fix-environment
Mar 31, 2026
Merged

Fix the environment used during deploy#269
frenck merged 1 commit into
hassio-addons:mainfrom
wbyoung:fix-environment

Conversation

@wbyoung
Copy link
Copy Markdown
Contributor

@wbyoung wbyoung commented Feb 28, 2026

Proposed Changes

The environment being pushed to is determined by the step and not by the output environment. For instance, when publishing a stable release, it should be published:

  • To the beta repository as a beta deployment
  • To the stable repository as a stable deployment

Before this change it would publish to the beta repository as a stable deployment (environment=stable).

Summary by CodeRabbit

  • Chores
    • Updated deployment configuration for application publishing workflows to utilize fixed environment names for edge, beta, and stable deployments.

The environment being pushed to is determined by the step and not by the
output environment. For instance, when publishing a stable release, it
should be published:

- To the beta repository as a beta deployment
- To the stable repository as a stable deployment

Before this change it would publish to the beta repository as a stable
deployment (environment=stable).
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bf24a85 and 4cdc09b.

📒 Files selected for processing (1)
  • .github/workflows/app-deploy.yaml

Walkthrough

Environment names in three GitHub Actions deployment jobs were changed from dynamic expressions referencing computed outputs to fixed literal values (edge, beta, stable), eliminating the dependency on computed environment selection for these publish steps.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Configuration
.github/workflows/app-deploy.yaml
Environment specifications for publish-edge, publish-beta, and publish-stable jobs changed from dynamic expression needs.information.outputs.environment to fixed literal values (edge, beta, stable respectively).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 No more guessing games for deployment's way,
Fixed paths now guide edge, beta, stable—hooray!
The outputs have spoken, the truth now stands clear,
Three tenants of certainty, loud and sincere! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: fixing the environment used during deployment by switching from dynamic environment expressions to fixed literals based on the deployment step.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions Bot added the stale There has not been activity on this issue or PR for quite some time. label Mar 31, 2026
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you @wbyoung 🫶

../Frenck

                       

Blogging my personal ramblings at frenck.dev

@frenck frenck merged commit 1903acf into hassio-addons:main Mar 31, 2026
@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label Mar 31, 2026
@wbyoung wbyoung deleted the fix-environment branch March 31, 2026 12:25
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix Inconsistencies or issues which will cause a problem for users or implementors. stale There has not been activity on this issue or PR for quite some time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants