Fix the environment used during deploy#269
Conversation
The environment being pushed to is determined by the step and not by the output environment. For instance, when publishing a stable release, it should be published: - To the beta repository as a beta deployment - To the stable repository as a stable deployment Before this change it would publish to the beta repository as a stable deployment (environment=stable).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
WalkthroughEnvironment names in three GitHub Actions deployment jobs were changed from dynamic expressions referencing computed outputs to fixed literal values (edge, beta, stable), eliminating the dependency on computed environment selection for these publish steps. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
Proposed Changes
The environment being pushed to is determined by the step and not by the output environment. For instance, when publishing a stable release, it should be published:
Before this change it would publish to the beta repository as a stable deployment (environment=stable).
Summary by CodeRabbit