Skip to content

Update imports in nodejs codecs #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

puzpuzpuz
Copy link
Contributor

Depends on #335

Node.js client counterpart PR: hazelcast/hazelcast-nodejs-client#570

@puzpuzpuz puzpuzpuz added Type: Cleanup 2.x client protocol 2.x related labels Aug 12, 2020
@puzpuzpuz puzpuzpuz self-assigned this Aug 12, 2020
@puzpuzpuz puzpuzpuz changed the title Move utils in nodejs codecs [WIP] Move utils in nodejs codecs Aug 12, 2020
@puzpuzpuz puzpuzpuz changed the title [WIP] Move utils in nodejs codecs [WIP] Update imports in nodejs codecs Aug 14, 2020
@puzpuzpuz puzpuzpuz changed the title [WIP] Update imports in nodejs codecs Update imports in nodejs codecs Aug 14, 2020
@puzpuzpuz puzpuzpuz requested a review from mdumandag August 14, 2020 08:26
@mdumandag
Copy link
Contributor

Do we need a rebase? I see the 7d5e7b97a99395b54f9ba4adf241bd346fbf39f1 and 6714bbc2a450e476b13a8593c560c6f4ec832943 are already on master

@puzpuzpuz puzpuzpuz force-pushed the cleanup/move-utils-in-nodejs-codecs branch from 3f163a3 to cfbc983 Compare August 18, 2020 06:23
@puzpuzpuz
Copy link
Contributor Author

Do we need a rebase? I see the 7d5e7b97a99395b54f9ba4adf241bd346fbf39f1 and 6714bbc2a450e476b13a8593c560c6f4ec832943 are already on master

@mdumandag ouch, my bad. Forgot to rebase this one. Done.

@puzpuzpuz puzpuzpuz merged commit 2e9cdef into hazelcast:master Aug 18, 2020
@puzpuzpuz puzpuzpuz deleted the cleanup/move-utils-in-nodejs-codecs branch August 18, 2020 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x client protocol 2.x related Type: Cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants