Skip to content

Add tests to code. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hballard opened this issue Feb 16, 2017 · 3 comments
Closed

Add tests to code. #1

hballard opened this issue Feb 16, 2017 · 3 comments

Comments

@hballard
Copy link
Owner

Initial implementation...no tests currently. Add tests.
@hballard hballard changed the title Add tests for code. Add tests to code. Feb 16, 2017
@hballard
Copy link
Owner Author

Added tests for subscription_manager module -- #12. Currently working to finish tests for subscription_transport_ws module. Should be done in a week or two and all primary tests for the repo will be complete.

@hballard
Copy link
Owner Author

Just added about half the tests for the subscriptions_transport.py module. It utilizes nodejs to execute the apollographql/subscriptions-transport-ws server tests using their subscription client (version [email protected]). Getting all the multiprocess / subprocess stuff took me a bit to get right (new to this), but now that most of the setup is working, shouldn't take long to finish up these tests. That still means it is currently behind their released version (as of 16 hrs ago) of 0.7.0.

@hballard hballard reopened this May 29, 2017
@hballard hballard mentioned this issue May 29, 2017
Closed
@hballard
Copy link
Owner Author

hballard commented Jun 8, 2017

Completed initial test suit for current implementation. See #13.

@hballard hballard closed this as completed Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hballard