Complete subscription_transport tests #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See notes in tests/test_subscription_transport.py for how to run tests. This implementation is based on the apollographql/subscriptions-transport-ws library and uses their graphql subscriptions client for testing. Specifically, these tests are compatable with npm package released version [email protected]. Tests are about halfway complete for that release version.
hballard
changed the title
Only two remaining tests to complete and this will bring the test coverage up the Apollo subscription-transport-ws libary 0.5.4 release.
Change class name to just "SubscriptionServer"
Modified "nonlocal" class to "non_local" dict and changed parameter['context'] defination statement
Also minor changes to test_susbcription_transport module
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See notes in tests/test_subscription_transport.py for how to run
tests. This implementation is based on the
apollographql/subscriptions-transport-ws library and uses their
graphql subscriptions client for testing. Specifically, these
tests are compatable with npm package released version
[email protected].
Tests are about halfway complete for that release version.