Launch

[hden]

• travisCI
• published on npm
• launch

cc @julianlam

[julianlam]

Ooh fancy. What happened to the original repo?

[hden]

I think the original repo should stay as it is until we figure out how to support both 1.0.x and 0.9.x. Any thought?

[julianlam]

Thanks @hden for implementing -- I did not know that the implementation was different until I tried implementing your library into NodeBB. Works well with a couple differences (socket.io-wildcard provided name and args, where as yours provides just data), but they are small and easily patched.

I'm waiting on some upstream changes, since 1.0 seems to have removed support for io.sockets.clients(roomName); and .roomClients(), both of which are used (socketio/socket.io#1428), so until then, this won't be in production... yet!

[hden]

The name and args are legacy from 0.9.x. On the other hand, data is the standard interface of the socket.io packet now. Should we normalise the difference in this project or leave it to user land?

[julianlam]

It's fine the way you've implemented it, no need to change what works. Thanks for publishing! 😄

[hden]

:D