Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/weave-scope] update weave-scope to 1.11.0 #13949

Merged
merged 5 commits into from
May 22, 2019
Merged

[stable/weave-scope] update weave-scope to 1.11.0 #13949

merged 5 commits into from
May 22, 2019

Conversation

dholbach
Copy link
Collaborator

Signed-off-by: Daniel Holbach [email protected]

What this PR does / why we need it:

Updates Weave Scope to the latest stable release.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • title of the PR contains starts with chart name e.g. [stable/chart]

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 17, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @dholbach. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 17, 2019
Daniel Holbach added 2 commits May 17, 2019 12:31
Signed-off-by: Daniel Holbach <[email protected]>
@dholbach dholbach changed the title [stable/weave-scope] update weave-scope to 1.10.2 [stable/weave-scope] update weave-scope to 1.11.0 May 21, 2019
@maorfr
Copy link
Member

maorfr commented May 21, 2019

/assign
/ok-to-test
/lgtm

thanks!

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. ok-to-test approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 21, 2019
	Bryan Boreham and Filip Barl are maintainers of Weave Scope
	(https://github.com/weaveworks/scope/blob/master/MAINTAINERS)

	Daniel Holbach helps out with releases and community management
	occasionally. We all work for Weaveworks.

	Thanks Maor Friedman for this suggestion!
	(https://kubernetes.slack.com/archives/C6E3XH1ED/p1558452865042400?thread_ts=1558452289.041500&cid=C6E3XH1ED)

Signed-off-by: Daniel Holbach <[email protected]>
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 21, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 21, 2019
@dholbach
Copy link
Collaborator Author

ccing @fbarl and @bboreham re: d5ba531

@maorfr
Copy link
Member

maorfr commented May 21, 2019

Would you mind also adding yourselves to Chart.yaml?

@maorfr
Copy link
Member

maorfr commented May 22, 2019

i have already added you all as collaborators :)

@dholbach
Copy link
Collaborator Author

Thanks @maorfr - done!

@dholbach
Copy link
Collaborator Author

/test pull-charts-e2e

@dholbach
Copy link
Collaborator Author

@maorfr Not sure if you can help with the failing test. I have no idea why this is happening.

@maorfr
Copy link
Member

maorfr commented May 22, 2019

/test pull-charts-e2e

i see no reason as well.

@dholbach
Copy link
Collaborator Author

Third time lucky? 🤞

@dholbach
Copy link
Collaborator Author

/test pull-charts-e2e

@maorfr
Copy link
Member

maorfr commented May 22, 2019

/retest

is it possible that this is failing?

curl --retry 12 --retry-delay 10 http://{{ .Values.global.service.name | default (include "toplevel.fullname" .) }}.{{ .Release.Namespace }}.svc:{{ .Values.global.service.port }}

@maorfr
Copy link
Member

maorfr commented May 22, 2019

/lgtm

passed passed! :)

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dholbach, maorfr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 91e81d8 into helm:master May 22, 2019
@dholbach dholbach deleted the weave-scope-1.10.2 branch May 22, 2019 10:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants