Port uv test improvements to other package manager tests

spec/fixtures/pip_editable/packages/local_package_pyproject_toml/local_package_pyproject_toml/__init__.py

@@ -1,2 +1,2 @@
 def hello():
-    print("Hello pyproject.toml!")
+    print("Hello from pyproject.toml!")

spec/fixtures/pip_editable/packages/local_package_setup_py/local_package_setup_py/__init__.py

@@ -1,2 +1,2 @@
 def hello():
-    print("Hello setup.py!")
+    print("Hello from setup.py!")

spec/fixtures/pipenv_editable/bin/test-entrypoints.sh

@@ -8,6 +8,9 @@ cd .heroku/python/lib/python*/site-packages/
 grep --extended-regexp --only-matching -- '/\S+' *.pth __editable___*_finder.py | sort
 echo
 
+echo -n "Running entrypoint for the current package: "
+pipenv-editable
+
 echo -n "Running entrypoint for the pyproject.toml-based local package: "
 local_package_pyproject_toml
 

spec/fixtures/pipenv_editable/packages/local_package_pyproject_toml/local_package_pyproject_toml/__init__.py

@@ -1,2 +1,2 @@
 def hello():
-    print("Hello pyproject.toml!")
+    print("Hello from pyproject.toml!")

spec/fixtures/pipenv_editable/packages/local_package_setup_py/local_package_setup_py/__init__.py

@@ -1,2 +1,2 @@
 def hello():
-    print("Hello setup.py!")
+    print("Hello from setup.py!")

spec/fixtures/pipenv_editable/pipenv_editable/__init__.py

@@ -0,0 +1,2 @@
+def main() -> None:
+    print("Hello from pipenv-editable!")

spec/fixtures/pipenv_editable/pyproject.toml

@@ -3,6 +3,9 @@ name = "pipenv-editable"
 version = "0.0.0"
 requires-python = ">=3.13"
 
+[project.scripts]
+pipenv-editable = "pipenv_editable:main"
+
 [build-system]
 requires = ["hatchling"]
 build-backend = "hatchling.build"

spec/fixtures/pipenv_mismatched_python_version/.python-version

@@ -0,0 +1,2 @@
+# The version here intentionally doesn't match `python_version` in Pipfile.lock
+3.13

spec/fixtures/pipenv_mismatched_python_version/Pipfile

@@ -0,0 +1,10 @@
+[[source]]
+url = "https://pypi.org/simple"
+verify_ssl = true
+name = "pypi"
+
+[packages]
+typing-extensions = "*"
+
+[requires]
+python_version = "3.12"

spec/fixtures/poetry_editable/bin/test-entrypoints.sh

@@ -8,6 +8,9 @@ cd .heroku/python/lib/python*/site-packages/
 grep --extended-regexp --only-matching -- '/\S+' *.pth __editable___*_finder.py | sort
 echo
 
+echo -n "Running entrypoint for the current package: "
+poetry-editable
+
 echo -n "Running entrypoint for the pyproject.toml-based local package: "
 local_package_pyproject_toml
 

spec/fixtures/poetry_editable/packages/local_package_pyproject_toml/local_package_pyproject_toml/__init__.py

@@ -1,2 +1,2 @@
 def hello():
-    print("Hello pyproject.toml!")
+    print("Hello from pyproject.toml!")

spec/fixtures/poetry_editable/packages/local_package_setup_py/local_package_setup_py/__init__.py

@@ -1,2 +1,2 @@
 def hello():
-    print("Hello setup.py!")
+    print("Hello from setup.py!")

spec/fixtures/poetry_editable/poetry_editable/__init__.py

@@ -0,0 +1,2 @@
+def main() -> None:
+    print("Hello from poetry-editable!")

spec/fixtures/poetry_editable/pyproject.toml

@@ -10,6 +10,9 @@ gunicorn = { git = "https://github.com/benoitc/gunicorn.git", develop = true }
 local-package-pyproject-toml = { path = "packages/local_package_pyproject_toml", develop = true }
 local-package-setup-py = { path = "packages/local_package_setup_py", develop = true }
 
+[tool.poetry.scripts]
+poetry-editable = 'poetry_editable:main'
+
 [build-system]
 requires = ["poetry-core"]
 build-backend = "poetry.core.masonry.api"

spec/fixtures/poetry_mismatched_python_version/.python-version

@@ -0,0 +1,2 @@
+# The version here intentionally doesn't match requires-python in pyproject.toml
+3.13

spec/fixtures/poetry_mismatched_python_version/pyproject.toml

@@ -0,0 +1,13 @@
+[project]
+name = "poetry-mismatched-python-version"
+version = "0.0.0"
+# This Python version intentionally doesn't match that in .python-version.
+# The version here also matches the distro Python version in Ubuntu 24.04,
+# so we can also test Poetry doesn't fall back to system Python.
+requires-python = "3.12.*"
+dependencies = [
+    "typing-extensions"
+]
+
+[tool.poetry]
+package-mode = false

spec/hatchet/pip_spec.rb

@@ -108,8 +108,8 @@
           remote:        gunicorn.egg-link:/app/.heroku/python/src/gunicorn
           remote:        local-package-setup-py.egg-link:/tmp/build_.+/packages/local_package_setup_py
           remote:        
-          remote:        Running entrypoint for the pyproject.toml-based local package: Hello pyproject.toml!
-          remote:        Running entrypoint for the setup.py-based local package: Hello setup.py!
+          remote:        Running entrypoint for the pyproject.toml-based local package: Hello from pyproject.toml!
+          remote:        Running entrypoint for the setup.py-based local package: Hello from setup.py!
           remote:        Running entrypoint for the VCS package: gunicorn \\(version 20.1.0\\)
           remote: -----> Inline app detected
           remote: easy-install.pth:/app/.heroku/python/src/gunicorn
@@ -118,8 +118,8 @@
           remote: gunicorn.egg-link:/app/.heroku/python/src/gunicorn
           remote: local-package-setup-py.egg-link:/tmp/build_.+/packages/local_package_setup_py
           remote: 
-          remote: Running entrypoint for the pyproject.toml-based local package: Hello pyproject.toml!
-          remote: Running entrypoint for the setup.py-based local package: Hello setup.py!
+          remote: Running entrypoint for the pyproject.toml-based local package: Hello from pyproject.toml!
+          remote: Running entrypoint for the setup.py-based local package: Hello from setup.py!
           remote: Running entrypoint for the VCS package: gunicorn \\(version 20.1.0\\)
         REGEX
 
@@ -131,8 +131,8 @@
           gunicorn.egg-link:/app/.heroku/python/src/gunicorn
           local-package-setup-py.egg-link:/app/packages/local_package_setup_py
 
-          Running entrypoint for the pyproject.toml-based local package: Hello pyproject.toml!
-          Running entrypoint for the setup.py-based local package: Hello setup.py!
+          Running entrypoint for the pyproject.toml-based local package: Hello from pyproject.toml!
+          Running entrypoint for the setup.py-based local package: Hello from setup.py!
           Running entrypoint for the VCS package: gunicorn (version 20.1.0)
         OUTPUT
 
@@ -147,8 +147,8 @@
           remote:        gunicorn.egg-link:/app/.heroku/python/src/gunicorn
           remote:        local-package-setup-py.egg-link:/tmp/build_.+/packages/local_package_setup_py
           remote:        
-          remote:        Running entrypoint for the pyproject.toml-based local package: Hello pyproject.toml!
-          remote:        Running entrypoint for the setup.py-based local package: Hello setup.py!
+          remote:        Running entrypoint for the pyproject.toml-based local package: Hello from pyproject.toml!
+          remote:        Running entrypoint for the setup.py-based local package: Hello from setup.py!
           remote:        Running entrypoint for the VCS package: gunicorn \\(version 20.1.0\\)
           remote: -----> Inline app detected
           remote: easy-install.pth:/app/.heroku/python/src/gunicorn
@@ -157,8 +157,8 @@
           remote: gunicorn.egg-link:/app/.heroku/python/src/gunicorn
           remote: local-package-setup-py.egg-link:/tmp/build_.+/packages/local_package_setup_py
           remote: 
-          remote: Running entrypoint for the pyproject.toml-based local package: Hello pyproject.toml!
-          remote: Running entrypoint for the setup.py-based local package: Hello setup.py!
+          remote: Running entrypoint for the pyproject.toml-based local package: Hello from pyproject.toml!
+          remote: Running entrypoint for the setup.py-based local package: Hello from setup.py!
           remote: Running entrypoint for the VCS package: gunicorn \\(version 20.1.0\\)
         REGEX
         # Test that the VCS repo checkout was cached correctly.

spec/hatchet/pipenv_spec.rb

@@ -407,17 +407,19 @@
           remote:        __editable___local_package_setup_py_0_0_1_finder.py:/tmp/build_.+/packages/local_package_setup_py/local_package_setup_py'}
           remote:        _pipenv_editable.pth:/tmp/build_.+
           remote:        
-          remote:        Running entrypoint for the pyproject.toml-based local package: Hello pyproject.toml!
-          remote:        Running entrypoint for the setup.py-based local package: Hello setup.py!
+          remote:        Running entrypoint for the current package: Hello from pipenv-editable!
+          remote:        Running entrypoint for the pyproject.toml-based local package: Hello from pyproject.toml!
+          remote:        Running entrypoint for the setup.py-based local package: Hello from setup.py!
           remote:        Running entrypoint for the VCS package: gunicorn \\(version 23.0.0\\)
           remote: -----> Inline app detected
           remote: __editable___gunicorn_23_0_0_finder.py:/app/.heroku/python/src/gunicorn/gunicorn'}
           remote: __editable___local_package_pyproject_toml_0_0_1_finder.py:/tmp/build_.+/packages/local_package_pyproject_toml/local_package_pyproject_toml'}
           remote: __editable___local_package_setup_py_0_0_1_finder.py:/tmp/build_.+/packages/local_package_setup_py/local_package_setup_py'}
           remote: _pipenv_editable.pth:/tmp/build_.+
           remote: 
-          remote: Running entrypoint for the pyproject.toml-based local package: Hello pyproject.toml!
-          remote: Running entrypoint for the setup.py-based local package: Hello setup.py!
+          remote: Running entrypoint for the current package: Hello from pipenv-editable!
+          remote: Running entrypoint for the pyproject.toml-based local package: Hello from pyproject.toml!
+          remote: Running entrypoint for the setup.py-based local package: Hello from setup.py!
           remote: Running entrypoint for the VCS package: gunicorn \\(version 23.0.0\\)
         REGEX
 
@@ -428,8 +430,9 @@
           __editable___local_package_setup_py_0_0_1_finder.py:/app/packages/local_package_setup_py/local_package_setup_py'}
           _pipenv_editable.pth:/app
 
-          Running entrypoint for the pyproject.toml-based local package: Hello pyproject.toml!
-          Running entrypoint for the setup.py-based local package: Hello setup.py!
+          Running entrypoint for the current package: Hello from pipenv-editable!
+          Running entrypoint for the pyproject.toml-based local package: Hello from pyproject.toml!
+          Running entrypoint for the setup.py-based local package: Hello from setup.py!
           Running entrypoint for the VCS package: gunicorn (version 23.0.0)
         OUTPUT
 
@@ -445,23 +448,41 @@
           remote:        __editable___local_package_setup_py_0_0_1_finder.py:/tmp/build_.+/packages/local_package_setup_py/local_package_setup_py'}
           remote:        _pipenv_editable.pth:/tmp/build_.+
           remote:        
-          remote:        Running entrypoint for the pyproject.toml-based local package: Hello pyproject.toml!
-          remote:        Running entrypoint for the setup.py-based local package: Hello setup.py!
+          remote:        Running entrypoint for the current package: Hello from pipenv-editable!
+          remote:        Running entrypoint for the pyproject.toml-based local package: Hello from pyproject.toml!
+          remote:        Running entrypoint for the setup.py-based local package: Hello from setup.py!
           remote:        Running entrypoint for the VCS package: gunicorn \\(version 23.0.0\\)
           remote: -----> Inline app detected
           remote: __editable___gunicorn_23_0_0_finder.py:/app/.heroku/python/src/gunicorn/gunicorn'}
           remote: __editable___local_package_pyproject_toml_0_0_1_finder.py:/tmp/build_.+/packages/local_package_pyproject_toml/local_package_pyproject_toml'}
           remote: __editable___local_package_setup_py_0_0_1_finder.py:/tmp/build_.+/packages/local_package_setup_py/local_package_setup_py'}
           remote: _pipenv_editable.pth:/tmp/build_.+
           remote: 
-          remote: Running entrypoint for the pyproject.toml-based local package: Hello pyproject.toml!
-          remote: Running entrypoint for the setup.py-based local package: Hello setup.py!
+          remote: Running entrypoint for the current package: Hello from pipenv-editable!
+          remote: Running entrypoint for the pyproject.toml-based local package: Hello from pyproject.toml!
+          remote: Running entrypoint for the setup.py-based local package: Hello from setup.py!
           remote: Running entrypoint for the VCS package: gunicorn \\(version 23.0.0\\)
         REGEX
       end
     end
   end
 
+  # This tests that Pipenv doesn't fall back to system Python if the Python version in
+  # pyproject.toml doesn't match that in Pipfile / Pipfile.lock.
+  context 'when requires-python in pyproject.toml is incompatible with .python-version',
+          skip: 'this is currently broken upstream: https://github.com/pypa/pipenv/issues/6403' do
+    let(:app) { Hatchet::Runner.new('spec/fixtures/pipenv_mismatched_python_version', allow_failure: true) }
+
+    it 'fails the build' do
+      app.deploy do |app|
+        expect(clean_output(app.output)).to include(<<~OUTPUT)
+          remote: -----> Installing dependencies using 'pipenv install --deploy'
+          remote:        <TODO whatever error message Pipenv displays if they fix their bug>
+        OUTPUT
+      end
+    end
+  end
+
   # This tests not only our handling of failing dependency installation, but also that we're running
   # Pipenv in such a way that it errors if the lockfile is out of sync, rather than simply updating it.
   context 'when the Pipfile.lock is out of sync with Pipfile' do

spec/hatchet/poetry_spec.rb

@@ -115,17 +115,19 @@
           remote:        __editable___local_package_setup_py_0_0_1_finder.py:/tmp/build_.+/packages/local_package_setup_py/local_package_setup_py'}
           remote:        poetry_editable.pth:/tmp/build_.+
           remote:        
-          remote:        Running entrypoint for the pyproject.toml-based local package: Hello pyproject.toml!
-          remote:        Running entrypoint for the setup.py-based local package: Hello setup.py!
+          remote:        Running entrypoint for the current package: Hello from poetry-editable!
+          remote:        Running entrypoint for the pyproject.toml-based local package: Hello from pyproject.toml!
+          remote:        Running entrypoint for the setup.py-based local package: Hello from setup.py!
           remote:        Running entrypoint for the VCS package: gunicorn \\(version 23.0.0\\)
           remote: -----> Inline app detected
           remote: __editable___gunicorn_23_0_0_finder.py:/app/.heroku/python/src/gunicorn/gunicorn'}
           remote: __editable___local_package_pyproject_toml_0_0_1_finder.py:/tmp/build_.+/packages/local_package_pyproject_toml/local_package_pyproject_toml'}
           remote: __editable___local_package_setup_py_0_0_1_finder.py:/tmp/build_.+/packages/local_package_setup_py/local_package_setup_py'}
           remote: poetry_editable.pth:/tmp/build_.+
           remote: 
-          remote: Running entrypoint for the pyproject.toml-based local package: Hello pyproject.toml!
-          remote: Running entrypoint for the setup.py-based local package: Hello setup.py!
+          remote: Running entrypoint for the current package: Hello from poetry-editable!
+          remote: Running entrypoint for the pyproject.toml-based local package: Hello from pyproject.toml!
+          remote: Running entrypoint for the setup.py-based local package: Hello from setup.py!
           remote: Running entrypoint for the VCS package: gunicorn \\(version 23.0.0\\)
         REGEX
 
@@ -136,8 +138,9 @@
           __editable___local_package_setup_py_0_0_1_finder.py:/app/packages/local_package_setup_py/local_package_setup_py'}
           poetry_editable.pth:/app
 
-          Running entrypoint for the pyproject.toml-based local package: Hello pyproject.toml!
-          Running entrypoint for the setup.py-based local package: Hello setup.py!
+          Running entrypoint for the current package: Hello from poetry-editable!
+          Running entrypoint for the pyproject.toml-based local package: Hello from pyproject.toml!
+          Running entrypoint for the setup.py-based local package: Hello from setup.py!
           Running entrypoint for the VCS package: gunicorn (version 23.0.0)
         OUTPUT
 
@@ -161,17 +164,19 @@
           remote:        __editable___local_package_setup_py_0_0_1_finder.py:/tmp/build_.+/packages/local_package_setup_py/local_package_setup_py'}
           remote:        poetry_editable.pth:/tmp/build_.+
           remote:        
-          remote:        Running entrypoint for the pyproject.toml-based local package: Hello pyproject.toml!
-          remote:        Running entrypoint for the setup.py-based local package: Hello setup.py!
+          remote:        Running entrypoint for the current package: Hello from poetry-editable!
+          remote:        Running entrypoint for the pyproject.toml-based local package: Hello from pyproject.toml!
+          remote:        Running entrypoint for the setup.py-based local package: Hello from setup.py!
           remote:        Running entrypoint for the VCS package: gunicorn \\(version 23.0.0\\)
           remote: -----> Inline app detected
           remote: __editable___gunicorn_23_0_0_finder.py:/app/.heroku/python/src/gunicorn/gunicorn'}
           remote: __editable___local_package_pyproject_toml_0_0_1_finder.py:/tmp/build_.+/packages/local_package_pyproject_toml/local_package_pyproject_toml'}
           remote: __editable___local_package_setup_py_0_0_1_finder.py:/tmp/build_.+/packages/local_package_setup_py/local_package_setup_py'}
           remote: poetry_editable.pth:/tmp/build_.+
           remote: 
-          remote: Running entrypoint for the pyproject.toml-based local package: Hello pyproject.toml!
-          remote: Running entrypoint for the setup.py-based local package: Hello setup.py!
+          remote: Running entrypoint for the current package: Hello from poetry-editable!
+          remote: Running entrypoint for the pyproject.toml-based local package: Hello from pyproject.toml!
+          remote: Running entrypoint for the setup.py-based local package: Hello from setup.py!
           remote: Running entrypoint for the VCS package: gunicorn \\(version 23.0.0\\)
         REGEX
       end
@@ -236,6 +241,22 @@
     end
   end
 
+  # This tests that Poetry doesn't download its own Python or fall back to system Python
+  # if the Python version in pyproject.toml doesn't match that in .python-version.
+  context 'when requires-python in pyproject.toml is incompatible with .python-version',
+          skip: 'this is currently broken upstream: https://github.com/python-poetry/poetry/issues/10226' do
+    let(:app) { Hatchet::Runner.new('spec/fixtures/poetry_mismatched_python_version', allow_failure: true) }
+
+    it 'fails the build' do
+      app.deploy do |app|
+        expect(clean_output(app.output)).to include(<<~OUTPUT)
+          remote: -----> Installing dependencies using 'poetry sync --only main'
+          remote:        <TODO whatever error message Poetry displays if they fix their bug>
+        OUTPUT
+      end
+    end
+  end
+
   # This tests not only our handling of failing dependency installation, but also that we're running
   # Poetry in such a way that it errors if the lockfile is out of sync, rather than simply updating it.
   context 'when poetry.lock is out of sync with pyproject.toml' do