HHH-18885 test reproducing the issue #9331
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbellade
reviewed
May 27, 2025
hibernate-core/src/main/java/org/hibernate/collection/spi/PersistentMap.java
Outdated
Show resolved
Hide resolved
Extra lazy maps need to persist the added entry (key and value), not the added value. Let PersistentMap.AbstractMapValueDelayedOperation return the added entry so OneToManyPersister.writeIndex() can execute the queued operation.
mbellade
reviewed
May 27, 2025
Comment on lines
532
to
536
| @Override | ||
| public E getAddedEntry() { | ||
| // The (E) cast is very hacky because E is not Map.Entry but we need it to conform to PersistentCollection.queuedAdditionIterator() | ||
| return (E) Map.entry( getIndex(), getAddedInstance() ); | ||
| } |
There was a problem hiding this comment.
Suggested change
| @Override | |
| public E getAddedEntry() { | |
| // The (E) cast is very hacky because E is not Map.Entry but we need it to conform to PersistentCollection.queuedAdditionIterator() | |
| return (E) Map.entry( getIndex(), getAddedInstance() ); | |
| } | |
| @Override | |
| public Object getAddedEntry() { | |
| return Map.entry( getIndex(), getAddedInstance() ); | |
| } |
Comment on lines
1207
to
1210
|
|
||
| default E getAddedEntry() { | ||
| return getAddedInstance(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| default E getAddedEntry() { | |
| return getAddedInstance(); | |
| } | |
| default Object getAddedEntry() { | |
| return getAddedInstance(); | |
| } |
| @@ -849,7 +849,7 @@ public final Iterator<E> queuedAdditionIterator() { | |||
|
|
|||
| @Override | |||
| public E next() { | |||
| return operationQueue.get( index++ ).getAddedInstance(); | |||
| return operationQueue.get( index++ ).getAddedEntry(); | |||
There was a problem hiding this comment.
Let's keep the cast, but move it to here:
Suggested change
| return operationQueue.get( index++ ).getAddedEntry(); | |
| //noinspection unchecked | |
| return (E) operationQueue.get( index++ ).getAddedEntry(); |
There was a problem hiding this comment.
So queuedAdditionIterator() would still return an Iterator<E>, right? No an Iterator<?>?
There was a problem hiding this comment.
Yep, that's why you need the cast.
There was a problem hiding this comment.
I have moved the cast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test reproducing the issue: https://hibernate.atlassian.net/browse/HHH-18885
Putting a entity in an extra lazy map and committing the transaction results in a ClassCastException
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.