-
Notifications
You must be signed in to change notification settings - Fork 170
docs: improve explanation in transfer-tokens.js #3586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: improve explanation in transfer-tokens.js #3586
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Signed-off-by: Chaitanya-chute <[email protected]>
Signed-off-by: Chaitanya-chute <[email protected]>
8fdedaa to
c9de8ee
Compare
|
@ivaylonikolov7 Please review |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
|
i am not sure if adding these console.logs before each examples are necessary. Some of them are pretty obvious like the one that closes the client. I like the comment at the beginning of the example but the other ones are pretty self-explanatory. Also adding this to the |
Signed-off-by: Chaitanya-chute <[email protected]>
c43aa3e to
67ca124
Compare
|
@ivaylonikolov7 Thanks for the feedback! |
|
@ivaylonikolov7 Please review |
Description:
Improves readability of the
examples/transfer-tokens.jsby adding a high-level overview and inline explanatory comments.Related issue(s):
Fixes #3580
Checklist