-
Notifications
You must be signed in to change notification settings - Fork 33
Update dependencies (avro4s update) #1183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d48dcde
to
18a1989
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Have the error in the build happened in the past? I can't see why it is happening |
@alejandrohdezma You could try downgrading the Scala version. I'm not fully sure, but that error is familiar to me 🤔 |
Yes, it seems that's the problem. That scala version causes I checked it in this PR: #1184, where the error is different (Avro test failing, apparently). Thanks @alejandrohdezma ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thanks, @alejandrohdezma
b781c70
18a1989
to
b781c70
Compare
b781c70
to
82c3557
Compare
@juanpedromoreno downgrading Scala version again seemed to fixed the issue, but as you noticed the |
Can someone that knows their way around these tests help me troubleshoot it? There are so many logs that I'm a bit lost |
This test fails because of this update in `avro4s`: sksamuel/avro4s#594. It is a corner case that will occur only if all the following applies: - The user is generating IDLs from Scala code (it can never happen the other way around). - A field in a request/response is using a coproduct. - Said coproduct is using a generic type. - Said field has a default value. If all the previous checks, the generated schema will not contain the default value.
@franciscodr managed to find the cause of the errors and the "solution". As said in a232ee2, the only solution was to ignore the failing test. This test fails because of this update in It is a corner case that will occur only if all the following applies:
If all the previous checks, the generated schema will not contain the default value. We discussed it and concluded that it is such a small case that we are safe to go down this road. |
Codecov Report
@@ Coverage Diff @@
## main #1183 +/- ##
==========================================
- Coverage 84.98% 84.81% -0.17%
==========================================
Files 59 59
Lines 839 843 +4
Branches 1 1
==========================================
+ Hits 713 715 +2
- Misses 126 128 +2
Continue to review full report at Codecov.
|
What does this change do?
Updates all the updatable dependencies to their latest versions, except the ones that involve updating to cats-effect 3.0:
nowarn
annotations).cats-effect
to2.5.0
.log4cats
(is now under the Typelevel organization).avro4s
to4.0.7
(this involved a few removed parameters andDecoder
andEncoder
classes now including theSchemaFor
(instead of handling it implicitly).Checklist