-
Notifications
You must be signed in to change notification settings - Fork 1.1k
refactor(v2): upgrade module to github.com/alibaba/higress/v2 #2922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,12 +29,12 @@ comma := , | |
|
|
||
| # source packages to scan for kubetype-gen tags | ||
| kube_source_packages = $(subst $(space),$(empty), \ | ||
| github.com/alibaba/higress/api/networking/v1, \ | ||
| github.com/alibaba/higress/api/extensions/v1alpha1 \ | ||
| github.com/alibaba/higress/v2/api/networking/v1, \ | ||
| github.com/alibaba/higress/v2/api/extensions/v1alpha1 \ | ||
| ) | ||
|
|
||
| # base output package for generated files | ||
| kube_base_output_package = github.com/alibaba/higress/client/pkg | ||
| kube_base_output_package = github.com/alibaba/higress/v2/client/pkg | ||
| # base output package for kubernetes types, register, etc... | ||
| kube_api_base_package = $(kube_base_output_package)/apis | ||
| # source packages to scan for kubernetes generator tags, e.g. deepcopy-gen, client-gen, etc. | ||
|
|
@@ -72,7 +72,7 @@ else | |
| endif | ||
|
|
||
| rename_generated_files=\ | ||
| find $(subst github.com/alibaba/higress/client/, $(empty), $(subst $(comma), $(space), $(kube_api_packages)) $(kube_clientset_package) $(kube_listers_package) $(kube_informers_package)) \ | ||
| find $(subst github.com/alibaba/higress/v2/client/, $(empty), $(subst $(comma), $(space), $(kube_api_packages)) $(kube_clientset_package) $(kube_listers_package) $(kube_informers_package)) \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 修正了 rename_generated_files 中的路径替换逻辑。
📋 问题详情rename_generated_files 中的路径替换逻辑不正确,可能导致生成的文件重命名失败。具体来说, 💡 解决方案修正路径替换逻辑,确保生成的文件能够正确重命名。 - find $(subst github.com/alibaba/higress/v2/client/, $(empty), $(subst $(comma), $(space), $(kube_api_packages)) $(kube_clientset_package) $(kube_listers_package) $(kube_informers_package)) \\
- -name '*.go' -and -not -name 'doc.go' -and -not -name '*.gen.go' -type f -exec sh -c 'mv "$$1" "$${1%.go}".gen.go' - '{}' \;
+ find $(subst github.com/alibaba/higress/v2/client/, , $(subst $(comma), $(space), $(kube_api_packages)) $(kube_clientset_package) $(kube_listers_package) $(kube_informers_package)) \\
+ -name '*.go' -and -not -name 'doc.go' -and -not -name '*.gen.go' -type f -exec sh -c 'mv "$$1" "$${1%.go}".gen.go' - '{}' \;
|
||
| -name '*.go' -and -not -name 'doc.go' -and -not -name '*.gen.go' -type f -exec sh -c 'mv "$$1" "$${1%.go}".gen.go' - '{}' \; | ||
|
|
||
| .PHONY: generate-k8s-client | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为 RegistryConfig 消息的 type 字段添加了必需的字段行为注解。
📋 问题详情
在 RegistryConfig 消息中,type 字段被标记为必需,但缺少 google.api.field_behavior 注解。这可能导致生成的代码或文档不完整,影响 API 的清晰度和正确使用。
💡 解决方案
确保所有必需字段都包含适当的注解,以提高 API 的可读性和正确性。
有用意见👍 | 无用意见👎 | 错误意见❌