Skip to content

fix: update getRecentBlocks to use pox info from chain_tip #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

janniks
Copy link
Contributor

@janniks janniks commented Oct 28, 2024

fix: update getRecentBlocks to use pox info from chain_tip

@janniks janniks linked an issue Oct 28, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Oct 28, 2024

Vercel deployment URL: https://signer-metrics-qk59kyb1k-hirosystems.vercel.app 🚀

@janniks janniks force-pushed the 13-determine-cycle-number-more-robustly branch from 2d5c994 to 52a7196 Compare October 28, 2024 14:17
@janniks janniks marked this pull request as ready for review October 28, 2024 15:23
@janniks janniks requested a review from zone117x October 28, 2024 15:23
Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @janniks! I wanted to get some tests in place before merging in changes like this -- and they are now in place.

Can you rebase this onto latest so that they run?

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@rafaelcr
Copy link
Collaborator

@janniks is this ready to merge? or do we need any other changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

Determine cycle-number more robustly
3 participants