Skip to content

Conversation

@cctina516
Copy link

@cctina516 cctina516 commented May 7, 2025

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Note

This PR's edit button implementation follows the approach used in PR #450 to maintain consistency across the codebase.
Since PR #450 is still under review, this implementation may need to be updated if changes are made to the referenced PR.

Update

The edit button implementation is based on the PR#450 button version as of May 16. Better to QA PR#450 before this.

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented May 7, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link

aem-code-sync bot commented May 7, 2025

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to add-configs-edit May 12, 2025 19:38 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to add-configs-edit May 12, 2025 20:24 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to add-configs-edit May 12, 2025 20:48 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to add-configs-edit May 14, 2025 18:01 Inactive
@ericeoeur ericeoeur marked this pull request as ready for review May 15, 2025 15:35
ericeoeur
ericeoeur previously approved these changes May 15, 2025
Copy link

@ericeoeur ericeoeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericeoeur
Copy link

@cctina516 minor conflict due to merging of #450 , can you please resolve?

@aem-code-sync aem-code-sync bot temporarily deployed to add-configs-edit May 20, 2025 15:22 Inactive
@ericeoeur
Copy link

QA passed. will merge.

@ericeoeur ericeoeur merged commit b8c8dcd into integration May 20, 2025
4 checks passed
@ericeoeur ericeoeur deleted the add-configs-edit branch May 20, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants