Skip to content

chore: prevent error logs on each keystroke if user is typing url #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sirugh merged 2 commits into from
Jun 4, 2025
Merged

chore: prevent error logs on each keystroke if user is typing url #501

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
429e24f
prevent error logs on each keystroke if user is typing url
sirugh Jun 4, 2025
26c7440
Update tools/site-creator/site-creator.js
sirugh Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions tools/site-creator/site-creator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,17 @@ class SiteCreator extends LitElement {
const value = input.value.toLowerCase();
input.value = value; // Update the input field with lowercase value

const url = new URL(value);
const org = url.pathname.split('/')[1];
const repo = url.pathname.split('/')[2];
try {
const url = new URL(value);
const org = url.pathname.split('/')[1];
const repo = url.pathname.split('/')[2];

if (org && repo && url.hostname === 'github.com') {
this._status = null;
this._data = { org, repo };
if (org && repo && url.hostname === 'github.com') {
this._status = null;
this._data = { org, repo };
}
} catch (error) {
// Do not error when user is typing the url - validation happens on submit.
}
}

Expand Down