chore: remove outdated picker #762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Rugh <rugh@adobe.com>
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
sirugh
changed the title
devpatil7
added a commit
that referenced
this pull request
Oct 20, 2025
* chore: if config is missing or invalid, show a relevant error view (#714) Signed-off-by: Stephen Rugh <rugh@adobe.com> * Update Cart to 1.5.1-beta4 (#758) * test alpha * use beta * replace default root category value with a placeholder so that users know to update this Signed-off-by: Stephen Rugh <rugh@adobe.com> * chore: Check meta sku first (#761) * check meta sku first, fall back to url sku * no export for private Signed-off-by: Stephen Rugh <rugh@adobe.com> --------- Signed-off-by: Stephen Rugh <rugh@adobe.com> * remove outdated picker (#762) Signed-off-by: Stephen Rugh <rugh@adobe.com> * remove references to hardcoded customer group header (#764) Signed-off-by: Stephen Rugh <rugh@adobe.com> * Fix AEM Assets decimal dimension compatibility issue (#767) Co-authored-by: Dev Patil <40405790+devpatil7@users.noreply.github.com> * Upgrade integration branch to include Checkout release v2.1.0 (#766) * Upgrade integration branch to include Checkout release v2.1.0 * Increased temporarily the time to place an order * Rollback the time to 5000 * place-order tests fails constantly in PaaS, but not in SaaS * removed extra adobeLayer expect * update account and order packages to latest --------- Co-authored-by: Miquel Angel Coca Piza <cocapiza@Miquels-MacBook-Pro.local> Co-authored-by: Natxo Cabré <cabre@adobe.com> Co-authored-by: Natxo Cabré <natxo.cabre@gmail.com> Co-authored-by: Dev Patil <depatil@adobe.com> * upgrade to latest auth (#770) * update dropin tools (#771) * removed duplicate code * ACAP-1130 (#760) * Fix preloadMiddleware when AEM assets integration is enabled * Fix preloadMiddleware for aem assets * update tools --------- Co-authored-by: Dev Patil <40405790+devpatil7@users.noreply.github.com> Co-authored-by: Dev Patil <depatil@adobe.com> * update search dropin (#776) * update search dropin * update to beta * disabled fastlane payment method (#777) * update tools and pdp to latest (#779) * upgrade dropin packages to latest production (#781) * upgrade dropin packages * update * update packages for Prex and Wishlist (#784) * New Checkout release version v2.1.0 (#786) Co-authored-by: Miquel Angel Coca Piza <cocapiza@Miquels-MacBook-Pro.local> * update root package version (#788) * sync package version with main * resolve package conflicts * Apply latest fixes of sdk Apply latest fixes of sdk --------- Signed-off-by: Stephen Rugh <rugh@adobe.com> Co-authored-by: Stephen <sirugh@users.noreply.github.com> Co-authored-by: Chuting (Christina) Yan <59424839+cctina516@users.noreply.github.com> Co-authored-by: Stephen Rugh <rugh@adobe.com> Co-authored-by: Amina <71978509+aminakhyat@users.noreply.github.com> Co-authored-by: Mike <cocapiza@adobe.com> Co-authored-by: Miquel Angel Coca Piza <cocapiza@Miquels-MacBook-Pro.local> Co-authored-by: Natxo Cabré <cabre@adobe.com> Co-authored-by: Natxo Cabré <natxo.cabre@gmail.com> Co-authored-by: Carlos A. Cabrera <cacabrer@adobe.com>
sirugh
added a commit
that referenced
this pull request
Oct 24, 2025
* Update cart to 1.5.0-beta1 (#638) * use latest alpha * use beta * ACAP-1061: Add AEM asset support for wishlist dropin (#643) * Add AEM asset support for wishlist dropin * skip wishlist test until support for ACCS * remove getProductLink * add tag to skip wishlist test in saas * bumped drop-in auth 2.1.0-alpha2 (#642) * hide category facet on category page (#636) Signed-off-by: Stephen Rugh <rugh@adobe.com> * Integrate enhanced Wishlist into boilerplate (#644) * IIntegrate enhanced Wishlist into boilerplate * fix cypress * Change protocol for expectedOptions * Use srcSetExpectedOptions --------- Co-authored-by: Dev Patil <depatil@adobe.com> * feat: Content Security Policy: strict-dynamic + (cached) nonce (#649) * feat: Content Security Policy: strict-dynamic + (cached) nonce * fix: 404 page not rendering * Update checkout dropin to v2.0.1-beta1 (#651) * Bump wishlist to version 2.0.0-beta1 (#653) Co-authored-by: Dev Patil <40405790+devpatil7@users.noreply.github.com> * update @storefront-recommendations to v1.1.0-beta1 (#654) * Update SDK to 1.4.0-beta3 and Cart to 1.5.0-beta2 (#648) * test alpha * use latest beta * udpate cart version --------- Co-authored-by: Dev Patil <40405790+devpatil7@users.noreply.github.com> * update dropins to latest (#655) * update to latest tools (#665) * Fix plp images (#661) * fix plp images * update to beta * fix tests * skip flaky tests (#663) * skip flaky tests * skip tests * unskip wishlist cypress saas tests (#660) Co-authored-by: Dev Patil <40405790+devpatil7@users.noreply.github.com> * update auth (#666) * default analytics env should be testing (#670) Signed-off-by: Stephen Rugh <rugh@adobe.com> * Server error does not appear in Safari browser (#669) * update tools (#672) * update @storefront-recommendations to v1.1.0-beta2 (#674) * Update SDK to 1.4.0-beta6 and Cart to 1.5.0-beta3 (#675) * use latest sdk * use cart beta * Unskip PaaS AEM Assets tests (#668) * test: remove skipPaas tags * test: fix inconsistencies --------- Co-authored-by: Dev Patil <40405790+devpatil7@users.noreply.github.com> * update dropins to latest (#676) * update dropins to latest * update * Upgrade Checkout dropin to v2.0.1 * update pdp version --------- Co-authored-by: merino <merino@adobe.com> * update root package version (#679) * Update Cart to 1.5.1-beta1 (#684) * test alpha * use beta * skip failing flaky tests --------- Co-authored-by: Dev Patil <depatil@adobe.com> * dont use pointer on non-interactive elements (#681) * support for metadata/schema - lowercase product sku in url (#406) * refactor into single commit over integration and moves files around using new structure. 5d5d382 for pre-refactor state Signed-off-by: Stephen Rugh <rugh@adobe.com> * dont use priceText if undefined Signed-off-by: Stephen Rugh <rugh@adobe.com> * fix price fetching Signed-off-by: Stephen Rugh <rugh@adobe.com> * rename checkSSGPage to isSsgPage Signed-off-by: Stephen Rugh <rugh@adobe.com> * remove pointer from all nav - just links should have pointer Signed-off-by: Stephen Rugh <rugh@adobe.com> * revert persisturl change Signed-off-by: Stephen Rugh <rugh@adobe.com> * Revert "remove pointer from all nav - just links should have pointer" This reverts commit 2fea686. * only apply jsonld and meta tags if not prerendered Signed-off-by: Stephen Rugh <rugh@adobe.com> * Update scripts/commerce.js * remove hydration logic: Signed-off-by: Stephen Rugh <rugh@adobe.com> * infer preload main image Signed-off-by: Stephen Rugh <rugh@adobe.com> * use aem fn for getMetadata Signed-off-by: Stephen Rugh <rugh@adobe.com> * helix only maps metadata for lowercase paths, but sku needs actual for client side requests, otherwise the page wont know how to transform the sku from the url Signed-off-by: Stephen Rugh <rugh@adobe.com> * force lowercase sku in plp Signed-off-by: Stephen Rugh <rugh@adobe.com> * utility function for product link creation Signed-off-by: Stephen Rugh <rugh@adobe.com> * make image extraction more robust Signed-off-by: Stephen Rugh <rugh@adobe.com> * fix lint Signed-off-by: Stephen Rugh <rugh@adobe.com> * generate JSON and provide upload instructions for DA Signed-off-by: Stephen Rugh <rugh@adobe.com> * use lowercase products urls Signed-off-by: Stephen Rugh <rugh@adobe.com> * running cicd * avoid false positive for isprerendered check incase other script adds unrelated jsonld Signed-off-by: Stephen Rugh <rugh@adobe.com> * metadata readme Signed-off-by: Stephen Rugh <rugh@adobe.com> * some missed lowercasings, incorrect urlKey Signed-off-by: Stephen Rugh <rugh@adobe.com> * add instructions for generating metadata in cypress Signed-off-by: Stephen Rugh <rugh@adobe.com> --------- Signed-off-by: Stephen Rugh <rugh@adobe.com> Co-authored-by: Stephen Rugh <rugh@adobe.com> Co-authored-by: Stephen <sirugh@users.noreply.github.com> * Product Discovery v2 (#671) * alpha package * Update storefront-product-discovery to version 2.0.0-alpha002, add yarn.lock file, and enhance search functionality in header component. * Update storefront-product-discovery to version 2.0.0-alpha003, bump tools to 1.4.1-alpha008, and enhance search functionality with pagination and improved event handling in product list page. Remove yarn.lock file. * Enhance filter parameter handling in product list page by decoding URL-encoded values and supporting single value filters. This improves the robustness of the getFilterFromParams function. * Refactor product list page search functionality to differentiate between category and search pages. Implement category filtering for category pages and adjust filter handling accordingly. Update facets rendering to anchor to the root category. * Refactor product list page to clarify search request handling on block load, improving code readability and maintainability. * fix linting * Update storefront-product-discovery to version 2.0.0-alpha004, reflecting changes in package-lock.json and package.json. Enhance Facet component to include an optional 'last' prop for improved layout handling in facets rendering. Adjust SortBy component to ensure required prop is set for Picker component. * Implement empty state styling for product list page and enhance search result handling. Add CSS rules to manage the display of elements when no products are found, and update JavaScript to reflect filter counts dynamically in the UI. * Enhance header search result styling with new CSS rules for product item cards and skeletons. Introduce grid layout for better display and adjust skeleton item dimensions for improved visual consistency. * lint * Enhance pagination functionality in product list page by adding smooth scroll to top on page change. This improves user experience during navigation. * Refactor pagination on product list page to simplify onPageChange handler. This change maintains smooth scrolling to the top while improving code clarity. * Update storefront-product-discovery to version 2.0.0-alpha005, reflecting changes in package-lock.json and package.json. Refactor search handling to improve clarity and maintainability, including updates to the SortBy component and enhancements to the search API for better metadata management. * lint * Update @dropins/tools to version 1.4.0-beta5 in package.json and package-lock.json. Refactor header CSS for product item cards to streamline layout and improve styling consistency. Adjust product list page CSS for pagination layout. Enhance JavaScript in header to expose events globally for better event handling. * Remove global exposure of events in header JavaScript to improve encapsulation and maintainability. * Update storefront-product-discovery to version 2.0.0-alpha006. Refactor search handling in Cypress tests to improve element selectors and enhance test reliability. Adjust CSS for product discovery components to streamline layout and improve styling consistency. * Fixed Cypress tests. Normalized border in Product Item Card. * fix sort labels * Refactor empty state layout and add error handling for product search - Updated CSS for the empty state of the product list page to change grid layout. - Added error handling in JavaScript for product search functionality to log errors in case of failure. * Update storefront-product-discovery to version 2.0.0-alpha008 * Removed `rootCategory` from Facets container. Not longer used. - Updated the rendering of the Facets component to remove the rootCategory prop, simplifying the implementation. * Update storefront-product-discovery to version 2.0.0-alpha010 * Update storefront-product-discovery to version 2.0.0-alpha11 and remove unused rootCategory prop from Facets component. Simplified Facets rendering by eliminating the rootCategory parameter. * skip aem tests * Update Filters button label to use dynamic value from AEM * Fixed i18n * fixed label * version bump --------- Co-authored-by: Dev Patil <40405790+devpatil7@users.noreply.github.com> Co-authored-by: Dev Patil <depatil@adobe.com> * fix metadata for multistore and jsonld path (#686) Signed-off-by: Stephen Rugh <rugh@adobe.com> Co-authored-by: Dev Patil <40405790+devpatil7@users.noreply.github.com> * [USF-2728] Fix placeholder data loss bug (#689) * Fix placeholder data loss bug in fetchPlaceholders function - return accumulated data instead of latest fetch only * fix cypress --------- Co-authored-by: Dev Patil <depatil@adobe.com> * update product path * Update SDK to 1.5.0-beta1 (#694) * test alpha * use beta * clean up readme (#695) Signed-off-by: Stephen Rugh <rugh@adobe.com> * feature: fallback to "commerce-endpoint" if only one is defined. (#700) * fallback to commerce-endpoint if core-endpoint not defined Signed-off-by: Stephen Rugh <rugh@adobe.com> * hardcoded example config of single endpoint Signed-off-by: Stephen Rugh <rugh@adobe.com> * Delete config.json * Update blocks/commerce-checkout/commerce-checkout.js --------- Signed-off-by: Stephen Rugh <rugh@adobe.com> * Bug Fix: PDP state overwritten when multiple PDPs are loaded on the same page (#696) * Update storefront-pdp to version 1.3.1-alpha001 and enhance API functionality This update aims to enhance the modularity and usability of the storefront PDP components. * Update storefront-pdp to version 2.0.0-alpha100 and tools to version 1.4.1-alpha100; refactor rendering in commerce-mini-pdp for improved readability * Update storefront-pdp to version 1.3.1-alpha101 and tools to version 1.4.1-alpha101 in package.json. * bump * Update storefront-pdp to version 1.3.1-alpha102 and tools to version 1.4.1-alpha102 * Refactor fallbackData structure in commerce-mini-pdp for improved clarity and maintainability * Update storefront-pdp to version 1.3.1-alpha103 and tools to version 1.4.1-alpha103; refactor ProductOptions component for improved data handling * update tools and pdp versions --------- Co-authored-by: Dev Patil <depatil@adobe.com> * Update SDK to 1.5.0-beta2 (#705) * test alpha * use beta * resolve merge conflicts from main * INTERNAL: Inject payment services lang definitions (#704) * Add test coverage and integrate percy visual regression (#600) * fix zoom * Integrate Percy * update * update percy scope * update * local cypress launch script * search test * update product search * update * update my account test * update * update * update * update * update * update tests * update * fix tests * update * update flow * update * update * update * update * update * update * update * update * update * Debug mobile percy (#712) * check updates * debug * update * update * update * update * update * update * update * update * update * update * update to include all screens * update * update * chore: if config is missing or invalid, show a relevant error view (#714) Signed-off-by: Stephen Rugh <rugh@adobe.com> * update wishlis version (#713) * Update Cart to 1.5.1-beta2 (#716) * test alpha * use beta --------- Co-authored-by: Dev Patil <40405790+devpatil7@users.noreply.github.com> * Update ACDL Scripts (#711) * Update Adobe Client Data Layer to version 3.0.0 and remove ajv2020 validation scripts - Updated the dependency for @adobe/adobe-client-data-layer to version 3.0.0 in package.json and package-lock.json. - Added new files for the Adobe Client Data Layer in the postinstall script. - Removed ajv2020.min.js and validate.js files as part of the cleanup. - Adjusted commerce.js to remove validation initialization for the Adobe Client Data Layer. * Update Adobe Client Data Layer to version 3.0.1 in package.json and package-lock.json; update minified script and source map for compatibility. --------- Co-authored-by: Dev Patil <40405790+devpatil7@users.noreply.github.com> * Fix Update cart API - USF 2503 (#702) * when only updating quantity * use cart alpha * fix lint * commit after install --------- Co-authored-by: Dev Patil <40405790+devpatil7@users.noreply.github.com> * Disable Fastlane in checkout * update @storefront-recommendations to v1.1.1-beta1 (#717) * update @storefront-recommendations to v1.1.1-beta1 * moves the mini-pdp to a components folder as it is not a block (#722) * moves the mini-pdp to a components folder as it is not a block Signed-off-by: Stephen Rugh <rugh@adobe.com> * missed path Signed-off-by: Stephen Rugh <rugh@adobe.com> --------- Signed-off-by: Stephen Rugh <rugh@adobe.com> Co-authored-by: Dev Patil <40405790+devpatil7@users.noreply.github.com> * Update Percy build trigger (#718) * Update SDK to 1.5.0-beta3 (#727) * use alpha * use beta * [docs] Add Commerce Block README files (#728) * generated readmes for each commerce block Signed-off-by: Stephen Rugh <rugh@adobe.com> * uses comments to hide readme sections that do not have useful content Signed-off-by: Stephen Rugh <rugh@adobe.com> * add comments around each excluded markdwon section Signed-off-by: Stephen Rugh <rugh@adobe.com> * Add automation for block README checks * fixed commerce-checkout README: one-page checkout, duplicated order/placed * move husky precommit script Signed-off-by: Stephen Rugh <rugh@adobe.com> * prevent commit without verify Signed-off-by: Stephen Rugh <rugh@adobe.com> --------- Signed-off-by: Stephen Rugh <rugh@adobe.com> Co-authored-by: Natxo Cabré <cabre@adobe.com> * Upgrade PDP and tests for PDP and Cart (#729) * Update Percy build trigger * update * update to latest PDP * Include gift card container * update test * Cover giftcard * Update storefront-pdp version * Update pdp version * Update pdp version to 1.3.4 * update * check qty --------- Co-authored-by: Stefan Perju <sperju@adobe.com> Co-authored-by: Stephen <sirugh@users.noreply.github.com> * Update Cart to 1.5.1-beta3 (#734) * use alpha * use beta * USF-2822: update wihslist readme (#737) * PAY-6280: Upgrade NPM deps to avoid supply-chain vulnerability (#741) Upgrade NPM packages beyond versions vulnerable to the recent NPM supply chain attack to rule out the possibility of upgrading to a vulnerable version. - Upgrade 'chalk' 5.4.1 -> 5.6.2 (5.6.1 vulnerable) - Upgrade 'ansi-regex' 6.1.0 -> 6.2.2 (6.2.1 vulnerable) - Upgrade 'ansi-styles' 6.2.1 -> 6.2.3 (6.2.2 vulnerable) - Upgrade 'strip-ansi' 7.1.0 -> 7.1.2 (7.1.1 vulnerable) - Upgrade 'wrap-ansi' 9.0.0 -> 9.0.2 (9.0.1 vulnerable) - Upgrade 'error-ex' 1.3.2 -> 1.3.4 (1.3.3 vulnerable) * update @storefront-recommendations to v1.1.1-beta2 (#742) * add commerce-assets-enabled: false to demo-config Signed-off-by: Stephen Rugh <rugh@adobe.com> * use beta (#746) * Update Cart to 1.5.1-beta4 (#758) * test alpha * use beta * replace default root category value with a placeholder so that users know to update this Signed-off-by: Stephen Rugh <rugh@adobe.com> * chore: Check meta sku first (#761) * check meta sku first, fall back to url sku * no export for private Signed-off-by: Stephen Rugh <rugh@adobe.com> --------- Signed-off-by: Stephen Rugh <rugh@adobe.com> * remove outdated picker (#762) Signed-off-by: Stephen Rugh <rugh@adobe.com> * remove references to hardcoded customer group header (#764) Signed-off-by: Stephen Rugh <rugh@adobe.com> * Fix AEM Assets decimal dimension compatibility issue (#767) Co-authored-by: Dev Patil <40405790+devpatil7@users.noreply.github.com> * Upgrade integration branch to include Checkout release v2.1.0 (#766) * Upgrade integration branch to include Checkout release v2.1.0 * Increased temporarily the time to place an order * Rollback the time to 5000 * place-order tests fails constantly in PaaS, but not in SaaS * removed extra adobeLayer expect * update account and order packages to latest --------- Co-authored-by: Miquel Angel Coca Piza <cocapiza@Miquels-MacBook-Pro.local> Co-authored-by: Natxo Cabré <cabre@adobe.com> Co-authored-by: Natxo Cabré <natxo.cabre@gmail.com> Co-authored-by: Dev Patil <depatil@adobe.com> * upgrade to latest auth (#770) * update dropin tools (#771) * removed duplicate code * ACAP-1130 (#760) * Fix preloadMiddleware when AEM assets integration is enabled * Fix preloadMiddleware for aem assets * update tools --------- Co-authored-by: Dev Patil <40405790+devpatil7@users.noreply.github.com> Co-authored-by: Dev Patil <depatil@adobe.com> * update search dropin (#776) * update search dropin * update to beta * disabled fastlane payment method (#777) * update tools and pdp to latest (#779) * upgrade dropin packages to latest production (#781) * upgrade dropin packages * update * update packages for Prex and Wishlist (#784) * New Checkout release version v2.1.0 (#786) Co-authored-by: Miquel Angel Coca Piza <cocapiza@Miquels-MacBook-Pro.local> * update root package version (#788) * Hotfix - SDK 1.5.1 (#796) * test beta * use final * Add attribute filter by search visibility (#793) (#794) * Add attribute filter by search visibility (#793) * Add attribute filter by search visibility --------- Co-authored-by: Oleg Posyniak <posyniak@adobe.com> Co-authored-by: Dev Patil <40405790+devpatil7@users.noreply.github.com> --------- Signed-off-by: Stephen Rugh <rugh@adobe.com> Co-authored-by: Chuting (Christina) Yan <59424839+cctina516@users.noreply.github.com> Co-authored-by: Amina <71978509+aminakhyat@users.noreply.github.com> Co-authored-by: Natxo Cabré <natxo.cabre@gmail.com> Co-authored-by: Marc Ginesta <loginesta@gmail.com> Co-authored-by: Dev Patil <depatil@adobe.com> Co-authored-by: Andrei Tuicu <andrei.tuicu@gmail.com> Co-authored-by: OscarMerino <merino@adobe.com> Co-authored-by: Dev Patil <40405790+devpatil7@users.noreply.github.com> Co-authored-by: Anthoula Wojczak <anthoula@users.noreply.github.com> Co-authored-by: eliseacornejo <ecornejo@adobe.com> Co-authored-by: Ivan Porto Wigner <dev.ivanporto@gmail.com> Co-authored-by: miakobchuk <miakobchuk@gmail.com> Co-authored-by: Carlos A. Cabrera <316104+fnhipster@users.noreply.github.com> Co-authored-by: Jordi Ortolá Ankum <jortolaankum@adobe.com> Co-authored-by: Virginie Faure <virfaure@gmail.com> Co-authored-by: Natxo Cabré <cabre@adobe.com> Co-authored-by: Stefan Perju <sperju@adobe.com> Co-authored-by: Mike <cocapiza@adobe.com> Co-authored-by: Miquel Angel Coca Piza <cocapiza@Miquels-MacBook-Pro.local> Co-authored-by: Carlos A. Cabrera <cacabrer@adobe.com> Co-authored-by: Oleg Posyniak <posyniak@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The picker in the tools/ folder was not maintained.
There is a newer one for use. @hannessolo will provide link/docs.
Test URLs: