Skip to content

Check all properties in onHover to avoid crashes #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2021
Merged

Check all properties in onHover to avoid crashes #426

merged 1 commit into from
May 4, 2021

Conversation

andreasg123
Copy link
Contributor

Fixes #425

Change List

  • Check every property of the info parameter in onHover before accessing sub-properties.

Checklist

  • Make sure Avivator works as expected with your change.

@ilan-gold ilan-gold merged commit 936c5bf into hms-dbmi:master May 4, 2021
ilan-gold added a commit that referenced this pull request May 26, 2021
@ilan-gold @manzt
@andreasg123 @dependabot
merge (#444)
f2a7309 
* Fix Interleaved RGB Image Handling. (#399)

* Fix Interleaved RGB Image Handling.

* Prettier.

* Defaults for photometricInterpretation

* Add test for Interleaved BitmapLayer (#400)

* Add test for BitmapLayer

* Add more stringent requirement for layer.

* Fix slicing bug.

* Fix tests better.

* Small fixes.

* ImageLayer too.

* 0.9.4 (#405)

* Fix type/docs for VivView(er) and Consumers. (#407)

* Fix type/docs for VivViewer and VivView (and upstream users)

* Use special jsdoc -> typescript syntax.

* Small Fixes

* Fix ImageLayer

* Try functional component

* Small fixes.

* Small fixes.

* Fix `ImageLayer` `loader` type. (#410)

* Improve emitted TS types for layers (#413)

* Create `Viv` utility type to refine emitted Layer constructor types.

* Do not export VivProps type.

* Fix Empty Loader Selection Bug. (#416)

* 0.9.5 (#417)

* Fix Bugs in `getChannelStats`. (#419)

* Fix Bugs in `getChannelStats`.

* Use > 0 instead of epsilon value.

* Check all properties in onHover to avoid crashes (#426)

* Bump url-parse from 1.4.7 to 1.5.1 in /avivator (#427)

Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.4.7 to 1.5.1.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](unshiftio/url-parse@1.4.7...1.5.1)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump hosted-git-info from 2.8.8 to 2.8.9 (#429)

Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](npm/hosted-git-info@v2.8.8...v2.8.9)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump lodash from 4.17.20 to 4.17.21 in /avivator (#431)

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.20...4.17.21)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump postcss from 8.1.4 to 8.2.15 in /avivator (#432)

Bumps [postcss](https://github.com/postcss/postcss) from 8.1.4 to 8.2.15.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.1.4...8.2.15)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump lodash from 4.17.20 to 4.17.21 (#428)

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.20...4.17.21)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Check for dependabot before running CHANGELOG checks (#433)

* New README Screenshots (#435)

* Add Screenshots for README

* Change width.

* Update URLs

* Allow for LINEAR/NEAREST Filtering Interpolation Choice (#437)

* Allow for LINEAR/NEAREST Filtering Interpolation Choice

* Change variable name

* Change filtering options.

* Bump browserslist from 4.16.1 to 4.16.6 (#441)

Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.16.1 to 4.16.6.
- [Release notes](https://github.com/browserslist/browserslist/releases)
- [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md)
- [Commits](browserslist/browserslist@4.16.1...4.16.6)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump browserslist from 4.14.6 to 4.16.6 in /avivator (#442)

Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.14.6 to 4.16.6.
- [Release notes](https://github.com/browserslist/browserslist/releases)
- [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md)
- [Commits](browserslist/browserslist@4.14.6...4.16.6)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Trevor Manz <[email protected]>
Co-authored-by: Andreas Girgensohn <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ilan-gold added a commit that referenced this pull request May 26, 2021
@ilan-gold @manzt
@andreasg123 @dependabot
merge (#445)
d3e5bff 
* Fix Interleaved RGB Image Handling. (#399)

* Fix Interleaved RGB Image Handling.

* Prettier.

* Defaults for photometricInterpretation

* Add test for Interleaved BitmapLayer (#400)

* Add test for BitmapLayer

* Add more stringent requirement for layer.

* Fix slicing bug.

* Fix tests better.

* Small fixes.

* ImageLayer too.

* 0.9.4 (#405)

* Fix type/docs for VivView(er) and Consumers. (#407)

* Fix type/docs for VivViewer and VivView (and upstream users)

* Use special jsdoc -> typescript syntax.

* Small Fixes

* Fix ImageLayer

* Try functional component

* Small fixes.

* Small fixes.

* Fix `ImageLayer` `loader` type. (#410)

* Improve emitted TS types for layers (#413)

* Create `Viv` utility type to refine emitted Layer constructor types.

* Do not export VivProps type.

* Fix Empty Loader Selection Bug. (#416)

* 0.9.5 (#417)

* Fix Bugs in `getChannelStats`. (#419)

* Fix Bugs in `getChannelStats`.

* Use > 0 instead of epsilon value.

* Check all properties in onHover to avoid crashes (#426)

* Bump url-parse from 1.4.7 to 1.5.1 in /avivator (#427)

Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.4.7 to 1.5.1.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](unshiftio/url-parse@1.4.7...1.5.1)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump hosted-git-info from 2.8.8 to 2.8.9 (#429)

Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](npm/hosted-git-info@v2.8.8...v2.8.9)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump lodash from 4.17.20 to 4.17.21 in /avivator (#431)

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.20...4.17.21)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump postcss from 8.1.4 to 8.2.15 in /avivator (#432)

Bumps [postcss](https://github.com/postcss/postcss) from 8.1.4 to 8.2.15.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.1.4...8.2.15)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump lodash from 4.17.20 to 4.17.21 (#428)

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.20...4.17.21)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Check for dependabot before running CHANGELOG checks (#433)

* New README Screenshots (#435)

* Add Screenshots for README

* Change width.

* Update URLs

* Allow for LINEAR/NEAREST Filtering Interpolation Choice (#437)

* Allow for LINEAR/NEAREST Filtering Interpolation Choice

* Change variable name

* Change filtering options.

* Bump browserslist from 4.16.1 to 4.16.6 (#441)

Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.16.1 to 4.16.6.
- [Release notes](https://github.com/browserslist/browserslist/releases)
- [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md)
- [Commits](browserslist/browserslist@4.16.1...4.16.6)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump browserslist from 4.14.6 to 4.16.6 in /avivator (#442)

Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.14.6 to 4.16.6.
- [Release notes](https://github.com/browserslist/browserslist/releases)
- [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md)
- [Commits](browserslist/browserslist@4.14.6...4.16.6)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Trevor Manz <[email protected]>
Co-authored-by: Andreas Girgensohn <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilan-gold ilan-gold ilan-gold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VivViewerWrapper.onHover crashes if the onHover prop is passed to other deck.gl layers
2 participants
@andreasg123 @ilan-gold