Conversation
Developed version 2.0.17
Added new version of core lib.
…ntainerPodName, convert logs to debug and trace
MichaelRoeder
left a comment
MichaelRoeder
left a comment
There was a problem hiding this comment.
Great development! 🙂
- Did you ensure that the platform still runs on Docker Swarm? Or will this option disappear over time?
- Kubernetes file need documentation! What about a README.md in the kubernetes-yaml-files directory?
- You should add yourself as
@authorto the classes that you implemented / changed
Also, please have a look at the other comments.
| LOGGER.debug("Container observer initialized."); | ||
| } | ||
|
|
||
| private void dokcerswarmInit() throws Exception { |
There was a problem hiding this comment.
Typo in the method name. Please also use camel case, i.e., dockerSwarmInit
There was a problem hiding this comment.
sure, I thought docker swarm was one word.
| super.init(); | ||
| LOGGER.debug("Platform controller initialization started."); | ||
|
|
||
| switch (System.getenv("RUN_ON").toLowerCase()){ |
There was a problem hiding this comment.
- This is not the established way to access the environment in HOBBIT. Please use the configuration class that we established for that.
- Please ensure that the code is safe. In this case, there might be a null pointer because it is not guaranteed that
getenvreturns something.
| kubernetsInit(); | ||
| break; | ||
| default: | ||
| kubernetsInit(); |
There was a problem hiding this comment.
Please also add a log message, since the user should be aware that the platform "guesses" were it is.
| break; | ||
| } | ||
| case Commands.TASK_GENERATION_FINISHED: { | ||
| LOGGER.debug("Task generator finish: {}", sessionId); |
| break; | ||
| } | ||
| case Commands.BENCHMARK_READY_SIGNAL: { | ||
| LOGGER.debug("Ready signal: {}", sessionId); |
There was a problem hiding this comment.
"Benchmark Ready signal: {}"
| import org.apache.jena.rdf.model.Model; | ||
| import org.apache.jena.vocabulary.RDF; | ||
| import org.hobbit.controller.ConnectivityAssumptionUtils; | ||
| import org.hobbit.controller.containers.GitlabBasedImageManager; |
There was a problem hiding this comment.
When the tested class moves into a different package, the test classes should move, too.
| import org.apache.jena.vocabulary.RDF; | ||
| import org.apache.jena.vocabulary.RDFS; | ||
| import org.hobbit.controller.containers.ResourceInformationCollector; | ||
| import org.hobbit.controller.containers.docker.ResourceInformationCollectorImpl; |
There was a problem hiding this comment.
When the tested class moves into a different package, the test classes should move, too.
| import java.util.Collection; | ||
| import java.util.List; | ||
|
|
||
| import org.hobbit.controller.containers.docker.ContainerManagerImpl; |
There was a problem hiding this comment.
When the tested class moves into a different package, the test classes should move, too.
...form-controller/src/test/java/org/hobbit/controller/docker/VersionTagIdentificationTest.java
Outdated
Show resolved
Hide resolved
thanks :) |
3 participants
run the HOBBIT on Kubernetes