This repository was archived by the owner on Feb 3, 2023. It is now read-only.
Cause hc-test-fmt to error if any errors #1713
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zippy
approved these changes
Sep 19, 2019
thedavidmeister
approved these changes
Oct 1, 2019
There was a problem hiding this comment.
assuming this is just the pipefail and everything else is noise due to the merge conflict, i'm happy @maackle
|
@thedavidmeister everything is was a manual rustfmt run, because the holonix fmt fix isn't working, and we already have a bunch of code that fails the fmt check |
|
@maackle oh sure, that makes sense, i still approve |
|
Fixed in #1822 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
hc-test-fmtstopped failing. This makes it fail when there are fmt diffs.However
hn-rust-fmtis also broken, due to this error:Which is referenced here: rust-lang/rustfmt#3666. So, we have no way to fix the fmt errors that are now being reported by CI
changelog
Please check one of the following, relating to the CHANGELOG-UNRELEASED.md
thread 'main' panicked at 'bad span:
.:)', src/tools/rustfmt/src/source_map.rs:52:13- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)