AdGuard integration displays wrong processing speed

[kevinkk525]

The problem

The processing speed displayed by the integration is 1/10 of what it actually is. AdGuard reports an average processing speed of 35ms but in HASS it is 3.5ms.

AdGuardHome installation version 0.100.9 in lxc container.

Environment

• Home Assistant release with the issue: 0.105.5
• Last working Home Assistant release (if known):
• Operating environment (Hass.io/Docker/Windows/etc.): Docker
• Integration causing this issue: AdGuard
• Link to integration documentation on our website: https://www.home-assistant.io/integrations/adguard/

Problem-relevant configuration.yaml

Traceback/Error logs

Additional information

[probot-home-assistant]

Hey there @frenck, mind taking a look at this issue as its been labeled with a integration (adguard) you are listed as a codeowner for? Thanks!

[springstan]

IMHO this is a rounding error in python-adguard, see this line.

It uses the Adguard OpenApi, specifically this part:

avg_processing_time:
     type: "number"
     format: "float"
     description: "Average time in milliseconds on processing a DNS"
     example: 0.34

Although the description indicates that it returns in milliseconds, the example makes me believe that it returns it in seconds. That is why in python-adguard it is multiplied by 100 and then rounded to two decimal places. However, it should be multiplied by 1000 to convert from seconds to milliseconds.

That is all that I got so far 😄 @frenck should I open up a PR or do you want to fix it and test it with your system?