Plugwise Anna broken after upgrade; KeyError: 'setpoint'

[slootjes]

The problem

Plugwise Anna integration is no longer working.

Environment

• Home Assistant Core release with the issue: 0.108.5
• Last working Home Assistant Core release (if known): 0.106.5
• Operating environment (Home Assistant/Supervised/Docker/venv): Docker
• Integration causing this issue: Plugwise Anna
• Link to integration documentation on our website: https://www.home-assistant.io/integrations/plugwise/

Problem-relevant configuration.yaml

climate:
  - platform: plugwise
    name: Anna
    password: !secret plugwise_anna_password
    host: !secret plugwise_anna_ip

Traceback/Error logs

2020-04-16 18:39:40 ERROR (MainThread) [homeassistant.components.climate] plugwise: Error on device update!
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 324, in _async_add_entity
    await entity.async_device_update(warning=False)
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 476, in async_device_update
    await self.hass.async_add_executor_job(self.update)
  File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/homeassistant/homeassistant/components/plugwise/climate.py", line 279, in update
    self._presets = self._api.get_presets(self._domain_objects)
  File "/usr/local/lib/python3.7/site-packages/haanna/haanna.py", line 89, in get_presets
    presets = self.get_preset_dictionary(root, rule_id)
  File "/usr/local/lib/python3.7/site-packages/haanna/haanna.py", line 498, in get_preset_dictionary
    directive.find("then").attrib["setpoint"]
KeyError: 'setpoint'

Additional information

Plugwise Anna version: 4.0.15
Output of /core/rules: https://pastebin.com/YVeyhYWL

[probot-home-assistant]

Hey there @laetificat, @CoMPaTech, @bouwew, mind taking a look at this issue as its been labeled with a integration (plugwise) you are listed as a codeowner for? Thanks!

[CoMPaTech]

Hi @slootjes - we are aware of this, we have a PR ready in #33691 but it will probably take some time. If you are using HACS or know how to use a custom_component you are more than welcome to use https://github.com/plugwise/plugwise-beta until the new version is available.
(The new version and reason for the PR to take some time is that we switched to configuration using the GUI and we made the component async). We have quiet a few testers and users that are already happily using the custom_component until we've updated the HA-core component.

[slootjes]

Awesome, you folks are the best :) I'll try the custom component tomorrow and test it.

[slootjes]

I can confirm the beta component works as expected. Still the current component is broken so I think this should stay open until it's actually fixed?

[CoMPaTech]

Let's leave it open, I connected it to the PR to get i tracked and auto-close on merge of the PR. Thanks for testing and glad it works for you!

[Mariusthvdb]

Might I add this is still the case on HA 109.6 as posted in the community

I am aware we can use the beta version, as a matter of fact I do, as this core integration now forces us to do so.

Since the beta is not yet on the roadmap for HA 0.110, it would be very much appreciated a fix could be made to current core integration, allowing users to use core code, and not have to rely on beta code, not yet tested by the core dev team.

[CoMPaTech]

Hi @Mariusthvdb, short answer: unfortunately not - do note that the issue is with the API-module used (the old one). If anyone besides @bouwew or me is willing to write a PR against https://github.com/laetificat/haanna/ I'm very much willing to approve that and fix the manifest on the current integration, but we both are investing all our time in the PR which most probably will be 0.111 or later as we have more work after the initial reviews.

[Mariusthvdb]

that is no good news...

understanding as I am of your efforts on the beta, leaving a core integration broken for at least 2 upcoming releases is rather undesirable.
Especially since the root cause apparently is known and doesn't need a lot of investigation.

since the error is about 'set point' which used to be 'target_temperature': it wouldn't be as is male as that would it....

Shouldn't priority be at keeping core in order (and this really is a broken integration right now, we're not talking details), a beta version can be postponed without much ado.

not sure what the view of the core HA dev team is on this?

[CoMPaTech]

As it stands @bouwew is looking into it and believe me we hoped we had the PR in such state that it was ready for 0.108. It turns out it both wasn't and the core team have a lot of PRs in progress that each deserve time. I agree with you that we'd best fixed it already - but do note that the upcoming PR isn't about being beta, it's about giving more people access to a better and far stable API and better entities.

I'm very glad with @bouwew keeping track of a lot of things, if it's really only about that change there indeed should be less excuse and we could ask the core team for a simple version bump included with 110 (if there is still time to make that cut).

Basically: You are right, we should have fixed it already, but I can't reverse time. Bad judgement on my (or our) end.

If @bouwew has time and it's really only the setpoint, it's a go. But we've already found out that there could be more problems from simple assumptions. Thats the reason why we rewrote both the API and the integration - not only that, we thoroughly test the API to ensure assumptions are right. There was no such thing with the Anna-only API.

[Mariusthvdb]

cool. As said, fully appreciate all your efforts (and enjoying the beta..)
its just that if at all possible, Core HA should be kept unbroken ;-)

let me know it we can help testing a quick fix, be glad to.

[CoMPaTech]

Hi @Mariusthvdb - @bouwew just ensured we could have haanna 0.15 - I published it on pypi - if you are able to test by changing your local code (and/or manifest) in your HA installation that would be highly appreciated. We definitely need testing before asking core to approve the versionbump. (See this PR for code change to the py-file)