Skip to content

Conversation

MartinHjelmare
Copy link
Member

Breaking change

Proposed change

  • Handle RssiErrorReceived in the statistics sensor.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@Copilot Copilot AI review requested due to automatic review settings August 18, 2025 13:08
@MartinHjelmare MartinHjelmare requested a review from a team as a code owner August 18, 2025 13:08
@home-assistant
Copy link

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_js can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zwave_js Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@MartinHjelmare MartinHjelmare added this to the 2025.8.3 milestone Aug 18, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds error handling for Z-Wave RSSI (Received Signal Strength Indicator) sensor values by properly handling RssiErrorReceived exceptions. The change ensures that when RSSI measurements encounter specific error conditions, the sensor entity responds appropriately by setting its state to unavailable or unknown.

Key changes:

  • Enhanced error handling in statistics sensors to catch and process RssiErrorReceived exceptions
  • Added comprehensive test coverage for different RSSI error scenarios
  • Refactored statistics update logic to centralize error handling

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
homeassistant/components/zwave_js/sensor.py Added RssiErrorReceived exception handling and refactored statistics update logic
tests/components/zwave_js/test_sensor.py Added comprehensive test for RSSI error handling scenarios

@MartinHjelmare MartinHjelmare merged commit 15505cd into dev Aug 18, 2025
34 checks passed
@MartinHjelmare MartinHjelmare deleted the fix-zwave-rssi-error branch August 18, 2025 20:14
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zwave_js_server.exceptions.RssiErrorReceived
3 participants