Skip to content

Conversation

@FI-153
Copy link
Contributor

@FI-153 FI-153 commented Nov 7, 2025

Proposed change

This changes prevents the user from creating or updating an Area, Floor or Entity with aliases such as an empty string, or a string with just whitespace or an alias with leading or trailing whitespaces. In the latter case the alias is kept but the white spaces are stripped.
I have also added tests to verify that the behavior is as expected.

The reason for this changes comes from an issue I had with Speech-To-Phrase that would crash due to empty aliases in my configuration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • [ x] I understand the code I am submitting and can explain how it works.
  • [ x] The code change is tested and works locally.
  • [ x] Local tests pass. Your PR cannot be merged unless tests pass
  • [ x] There is no commented out code in this PR.
  • [ x] I have followed the development checklist
  • [ x] I have followed the perfect PR recommendations
  • [ x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ x] Tests have been added to verify that the new code works.
  • [ x] Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@FI-153 FI-153 requested a review from a team as a code owner November 7, 2025 16:49
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @FI-153

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

home-assistant bot commented Nov 7, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

home-assistant bot commented Nov 7, 2025

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (config) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of config can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign config Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@FI-153
Copy link
Contributor Author

FI-153 commented Nov 8, 2025

Thanks @Diegorro98 for the tip, I've updated all the functions that called strip twice

Copy link
Contributor

@Diegorro98 Diegorro98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good to me. Please, don't forget to sign the CLA, and once done that, mark as ready to review.

@FI-153 FI-153 marked this pull request as ready for review November 8, 2025 17:15
@home-assistant home-assistant bot marked this pull request as draft November 13, 2025 12:03
@FI-153 FI-153 requested a review from arturpragacz November 24, 2025 11:14
@MartinHjelmare MartinHjelmare changed the title Prevents empty aliases Prevent empty aliases in registries Nov 24, 2025
@FI-153 FI-153 marked this pull request as ready for review November 26, 2025 09:39
@MartinHjelmare MartinHjelmare marked this pull request as draft December 10, 2025 13:42
@FI-153 FI-153 marked this pull request as ready for review December 12, 2025 14:17
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 2025.12.4 milestone Dec 15, 2025
@MartinHjelmare MartinHjelmare merged commit 9863d34 into home-assistant:dev Dec 15, 2025
120 of 122 checks passed
kennedyshead pushed a commit to kennedyshead/hass-core that referenced this pull request Dec 16, 2025
Co-authored-by: J. Diego Rodríguez Royo <[email protected]>
Co-authored-by: Joost Lekkerkerker <[email protected]>
Co-authored-by: Martin Hjelmare <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants