-
-
Notifications
You must be signed in to change notification settings - Fork 36.3k
Prevent empty aliases in registries #156061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent empty aliases in registries #156061
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Co-authored-by: J. Diego Rodríguez Royo <[email protected]>
|
Thanks @Diegorro98 for the tip, I've updated all the functions that called strip twice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic looks good to me. Please, don't forget to sign the CLA, and once done that, mark as ready to review.
MartinHjelmare
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: J. Diego Rodríguez Royo <[email protected]> Co-authored-by: Joost Lekkerkerker <[email protected]> Co-authored-by: Martin Hjelmare <[email protected]>
Proposed change
This changes prevents the user from creating or updating an Area, Floor or Entity with aliases such as an empty string, or a string with just whitespace or an alias with leading or trailing whitespaces. In the latter case the alias is kept but the white spaces are stripped.
I have also added tests to verify that the behavior is as expected.
The reason for this changes comes from an issue I had with Speech-To-Phrase that would crash due to empty aliases in my configuration.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: