Skip to content

Conversation

@arturpragacz
Copy link
Contributor

Proposed change

Add integration_type: "service" to the Ping (ICMP) integration manifest. This integration provides ICMP ping network utility functionality.

Type of change

  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

🤖 Generated with Claude Code

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Copilot AI review requested due to automatic review settings December 2, 2025 11:10
@arturpragacz arturpragacz requested a review from jpbede as a code owner December 2, 2025 11:10
@home-assistant
Copy link

home-assistant bot commented Dec 2, 2025

Hey there @jpbede, mind taking a look at this pull request as it has been labeled with an integration (ping) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ping can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign ping Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR correctly changes the integration_type for the ping integration from "hub" to "service". The ping integration provides ICMP network monitoring utility functionality rather than managing multiple sub-devices, making "service" the appropriate classification.

Key Changes

  • Updated manifest.json to specify integration_type: "service"
  • Regenerated integrations.json to reflect the manifest change

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
homeassistant/components/ping/manifest.json Added integration_type: "service" field to correctly classify ping as a network utility service
homeassistant/generated/integrations.json Updated generated file to reflect the integration type change from "hub" to "service"

@arturpragacz arturpragacz merged commit 3a1a58d into dev Dec 2, 2025
42 checks passed
@arturpragacz arturpragacz deleted the ap/ping/add-integration-type branch December 2, 2025 11:23
@zweckj zweckj added this to the 2025.12.0 milestone Dec 2, 2025
frenck pushed a commit that referenced this pull request Dec 2, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants