Skip to content

Conversation

@mik-laj
Copy link
Contributor

@mik-laj mik-laj commented Dec 2, 2025

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings December 2, 2025 20:15
@mik-laj mik-laj requested a review from frenck as a code owner December 2, 2025 20:15
@home-assistant
Copy link

home-assistant bot commented Dec 2, 2025

Hey there @frenck, mind taking a look at this pull request as it has been labeled with an integration (wled) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of wled can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign wled Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@joostlek joostlek added this to the 2025.12.0 milestone Dec 2, 2025
@joostlek joostlek merged commit 520156a into home-assistant:dev Dec 2, 2025
39 of 40 checks passed
try:
device = await self._async_get_device(user_input[CONF_HOST])
except WLEDUnsupportedVersionError:
errors["base"] = "unsupported_version"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, I'd like to display the original error message here as well, but I have no idea how to do that. Any ideas?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use placeholders, but that isn't meant for big errors tbf

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we have this merged, I’m not going to worry about it any further.

Thank you very much for the quick review. It genuinely made me happy to see this change merged so fast. My previous PR for the WLED integration waited several months before it finally got merged, and this time we were even faster than the GitHub copilot.

My next step is the quality scale, since that was one of the missing pieces: #155482

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds proper handling for unsupported WLED firmware versions by catching WLEDUnsupportedVersionError exceptions throughout the integration and providing appropriate user feedback.

  • Handles unsupported version errors in both config flow (user and zeroconf) and coordinator
  • Raises ConfigEntryError with translatable messages when unsupported versions are detected
  • Adds comprehensive test coverage for the new error handling paths

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
homeassistant/components/wled/coordinator.py Catches WLEDUnsupportedVersionError in data update and raises ConfigEntryError with translation support
homeassistant/components/wled/config_flow.py Handles unsupported version errors in both user and zeroconf flows with appropriate error/abort responses
homeassistant/components/wled/strings.json Adds translation keys for unsupported version errors in config flow and exceptions sections
tests/components/wled/test_coordinator.py Adds test verifying that setup fails with proper error message when encountering unsupported versions
tests/components/wled/test_config_flow.py Adds tests for unsupported version handling in both user and zeroconf discovery flows

"message": "MAC address does not match the configured device. Expected to connect to device with MAC: {expected_mac}, but connected to device with MAC: {actual_mac}."
},
"unsupported_version": {
"message": "The WLED device's firmware version is not supported: {error}"
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message lacks actionable guidance for users. According to the coding guidelines, error messages should be clear and helpful. Consider providing specific steps users can take to resolve the issue, such as:

"message": "The WLED device's firmware version is not supported: {error}. Please update your WLED device firmware to a supported version."

This gives users a clear action they can take to resolve the problem.

Suggested change
"message": "The WLED device's firmware version is not supported: {error}"
"message": "The WLED device's firmware version is not supported: {error}. To fix this issue, please update your WLED device to the latest firmware version. You can find update instructions on the WLED website (https://kno.wled.ge/firmware-updates/) or in the WLED app."

Copilot uses AI. Check for mistakes.
@mik-laj mik-laj deleted the wled-unsupported-version branch December 2, 2025 20:30
frenck pushed a commit that referenced this pull request Dec 2, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants