Skip to content

Conversation

@agners
Copy link
Member

@agners agners commented Dec 2, 2025

Breaking change

Proposed change

Link to /config/storage in the "Data disk is running low on free space" repair issue so users can directly navigate to see what is consuming disk space.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Link to /config/storage in the "Data disk is running low on free space"
repair issue so users can directly navigate to see what is consuming disk
space.
@home-assistant
Copy link

home-assistant bot commented Dec 2, 2025

Hey there @home-assistant/supervisor, mind taking a look at this pull request as it has been labeled with an integration (hassio) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hassio can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign hassio Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the low disk space repair issue by adding a direct link to the storage page (/config/storage), making it easier for users to identify what is consuming disk space.

Key Changes

  • Updated the repair issue description to include a clickable link to the storage page
  • Added the storage_url placeholder to the EXTRA_PLACEHOLDERS dictionary for the free space issue

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
homeassistant/components/hassio/strings.json Updated the issue_system_free_space description to include a new link to the storage page alongside the existing help documentation link
homeassistant/components/hassio/const.py Added storage_url placeholder mapping to /config/storage in the EXTRA_PLACEHOLDERS dictionary for the free space issue

ISSUE_KEY_ADDON_DETACHED_ADDON_REMOVED: HELP_URLS,
ISSUE_KEY_SYSTEM_FREE_SPACE: {
"more_info_free_space": "https://www.home-assistant.io/more-info/free-space",
"storage_url": "/config/storage",
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests for the free space issue need to be updated to include the new storage_url placeholder. The tests in test_supervisor_issues_free_space and test_supervisor_issues_free_space_host_info_fail currently verify placeholders but don't include storage_url. The placeholders dict should include:

placeholders={
    "more_info_free_space": "https://www.home-assistant.io/more-info/free-space",
    "storage_url": "/config/storage",
    "free_space": "1.6",  # or "<2" depending on the test
}

Copilot uses AI. Check for mistakes.
@balloob balloob added this to the 2025.12.0 milestone Dec 3, 2025
@balloob balloob merged commit b6786c5 into home-assistant:dev Dec 3, 2025
66 checks passed
frenck pushed a commit that referenced this pull request Dec 3, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants