Skip to content

Conversation

@allenporter
Copy link
Contributor

@allenporter allenporter commented Dec 3, 2025

This includes a breaking change to the caching API that requires blowing away storage. We don't bother testing the migration since it was only used during beta. This was manually tested that it fixes the existing cache format issue.

Proposed change

Bump python-roborock to 3.9.1
Release notes: https://github.com/Python-roborock/python-roborock/releases/tag/v3.9.2
Changes: Python-roborock/python-roborock@v3.8.4...v3.9.2

This fixes a serialization issue and removes the old cache, which is done as a breaking change to simplify upgrade. This is manually tested, and removes the old cache that was only alive during beta. This is not unit tested since it was only alive in beta.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

This includes a breaking change to the caching API that requires blowing away storage. We don't bother testing the migration since it was only used during beta. This was manually tested that it fixes the existing cache format issue.
Copilot AI review requested due to automatic review settings December 3, 2025 07:46
@home-assistant
Copy link

home-assistant bot commented Dec 3, 2025

Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the python-roborock dependency from version 3.8.4 to 3.9.1 to fix a cache serialization issue. The library's breaking change in the caching API requires migrating to a new cache format (version 2), which is handled by wiping the old cache data that was only used during the integration's beta period.

Key changes:

  • Updated dependency version in manifest and requirements files
  • Implemented cache migration from version 1 to 2 by returning empty cache data
  • Replaced deprecated dataclasses.asdict() with CacheData.as_dict() and CacheData(**dict) with CacheData.from_dict()

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
homeassistant/components/roborock/manifest.json Updates python-roborock requirement to 3.9.1
requirements_all.txt Updates python-roborock dependency to 3.9.1
requirements_test_all.txt Updates python-roborock test dependency to 3.9.1
homeassistant/components/roborock/roborock_storage.py Implements cache migration logic, updates to new library API (from_dict/as_dict), removes unused dataclasses import, and bumps cache version to 2

Copy link
Member

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @allenporter 👍

@frenck frenck merged commit 31a0478 into home-assistant:dev Dec 3, 2025
63 checks passed
frenck pushed a commit that referenced this pull request Dec 3, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Roborock is not available after update to core-2025.12.0b3

3 participants