-
-
Notifications
You must be signed in to change notification settings - Fork 36.3k
Bump python-roborock to 3.9.2 #157815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump python-roborock to 3.9.2 #157815
Conversation
This includes a breaking change to the caching API that requires blowing away storage. We don't bother testing the migration since it was only used during beta. This was manually tested that it fixes the existing cache format issue.
|
Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR bumps the python-roborock dependency from version 3.8.4 to 3.9.1 to fix a cache serialization issue. The library's breaking change in the caching API requires migrating to a new cache format (version 2), which is handled by wiping the old cache data that was only used during the integration's beta period.
Key changes:
- Updated dependency version in manifest and requirements files
- Implemented cache migration from version 1 to 2 by returning empty cache data
- Replaced deprecated
dataclasses.asdict()withCacheData.as_dict()andCacheData(**dict)withCacheData.from_dict()
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
homeassistant/components/roborock/manifest.json |
Updates python-roborock requirement to 3.9.1 |
requirements_all.txt |
Updates python-roborock dependency to 3.9.1 |
requirements_test_all.txt |
Updates python-roborock test dependency to 3.9.1 |
homeassistant/components/roborock/roborock_storage.py |
Implements cache migration logic, updates to new library API (from_dict/as_dict), removes unused dataclasses import, and bumps cache version to 2 |
edenhaus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @allenporter 👍
Co-authored-by: Robert Resch <[email protected]>
This includes a breaking change to the caching API that requires blowing away storage. We don't bother testing the migration since it was only used during beta. This was manually tested that it fixes the existing cache format issue.
Proposed change
Bump python-roborock to 3.9.1
Release notes: https://github.com/Python-roborock/python-roborock/releases/tag/v3.9.2
Changes: Python-roborock/python-roborock@v3.8.4...v3.9.2
This fixes a serialization issue and removes the old cache, which is done as a breaking change to simplify upgrade. This is manually tested, and removes the old cache that was only alive during beta. This is not unit tested since it was only alive in beta.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: