Skip to content

Conversation

@Lash-L
Copy link
Contributor

@Lash-L Lash-L commented Dec 3, 2025

Breaking change

Proposed change

This fixes a bug from the refactor where the mop parser config is not properly passed in. This is a copy of how we previously made the data for config.

Should be included in patch version.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Dec 3, 2025

Hey there @allenporter, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug introduced during a refactor where the MapParserConfig was not being properly passed to the create_device_manager function in the Roborock integration. The fix restores the map parser configuration that was lost in the refactor, ensuring that map rendering options (like drawables, background visibility, and scale) are correctly applied.

Key changes:

  • Added MapParserConfig import and related constants to properly configure map parsing
  • Restored the map_parser_config parameter in the create_device_manager call with proper construction of drawables, background settings, and scale

Comment on lines +69 to +77
map_parser_config=MapParserConfig(
drawables=[
drawable
for drawable, default_value in DEFAULT_DRAWABLES.items()
if entry.options.get(DRAWABLES, {}).get(drawable, default_value)
],
show_background=entry.options.get(CONF_SHOW_BACKGROUND, False),
map_scale=MAP_SCALE,
),
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description indicates that "Tests have been added to verify that the new code works," but there are no test changes visible in this PR to verify that the map_parser_config parameter is being correctly passed to create_device_manager.

Consider adding a test that verifies:

  1. The map_parser_config parameter is passed to create_device_manager
  2. The MapParserConfig is constructed with the correct values from entry.options
  3. The drawables list comprehension correctly filters based on the options and defaults

Example test:

async def test_map_parser_config_passed(
    hass: HomeAssistant,
    mock_roborock_entry: MockConfigEntry,
    fake_create_device_manager: Mock,
) -> None:
    """Test that map_parser_config is correctly passed to create_device_manager."""
    await hass.config_entries.async_setup(mock_roborock_entry.entry_id)
    await hass.async_block_till_done()
    
    # Verify create_device_manager was called with map_parser_config
    assert fake_create_device_manager.call_args.kwargs["map_parser_config"] is not None
    map_config = fake_create_device_manager.call_args.kwargs["map_parser_config"]
    assert map_config.map_scale == MAP_SCALE

Copilot uses AI. Check for mistakes.
@allenporter allenporter added this to the 2025.12.1 milestone Dec 4, 2025
@allenporter allenporter merged commit 69f66ff into home-assistant:dev Dec 4, 2025
41 of 42 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Roborock map ignoring "show background" setting

3 participants