-
-
Notifications
You must be signed in to change notification settings - Fork 36.3k
Move out URL of Xiaomy_aquara from strings.json #157937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+21
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add description placeholders for API URL in user form.
Co-authored-by: Copilot <[email protected]>
Fix resolve comments from the PR.
Added error step URLs for invalid host and updated form display logic.
Add description placeholders for error handling in config flow.
Replaced hardcoded invalid host URL placeholders with ERROR_STEP_PLACEHOLDERS.
|
Hey there @Danielhiversen, @syssi, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
44 tasks
zweckj
approved these changes
Dec 4, 2025
Member
|
Moved this one into the patch release, to prevent translation issues with unused placeholders. ../Frenck Blogging my personal ramblings at frenck.dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cherry-picked
cla-signed
code-quality
integration: xiaomi_aqara
Quality Scale: No score
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Move out URL of Xiaomy_aquara from strings.json
Based on #155310.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: