Skip to content

Conversation

@jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Dec 4, 2025

Proposed change

Move out URL of Xiaomy_aquara from strings.json

Based on #155310.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

mishmanners and others added 10 commits December 4, 2025 10:52
Add description placeholders for API URL in user form.
Fix resolve comments from the PR.
Added error step URLs for invalid host and updated form display logic.
Add description placeholders for error handling in config flow.
Replaced hardcoded invalid host URL placeholders with ERROR_STEP_PLACEHOLDERS.
@home-assistant
Copy link

home-assistant bot commented Dec 4, 2025

Hey there @Danielhiversen, @syssi, mind taking a look at this pull request as it has been labeled with an integration (xiaomi_aqara) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of xiaomi_aqara can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign xiaomi_aqara Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@zweckj zweckj merged commit f108663 into dev Dec 4, 2025
36 checks passed
@zweckj zweckj deleted the urls-xiaomi_aqara branch December 4, 2025 11:59
@frenck frenck added this to the 2025.12.1 milestone Dec 4, 2025
@frenck
Copy link
Member

frenck commented Dec 4, 2025

Moved this one into the patch release, to prevent translation issues with unused placeholders.

../Frenck

                       

Blogging my personal ramblings at frenck.dev

@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants