Skip to content

Conversation

@epenet
Copy link
Contributor

@epenet epenet commented Dec 4, 2025

Proposed change

Support for TEMP_UNIT_CONVERT data point was accidentaly removed in #156977

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings December 4, 2025 14:45
@home-assistant
Copy link

home-assistant bot commented Dec 4, 2025

Hey there @tuya, @zlinoliver, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tuya can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tuya Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a regression where support for the TEMP_UNIT_CONVERT data point was accidentally removed in PR #156977. The fix restores the ability for Tuya climate entities to properly parse and use temperature units from devices that expose a temperature unit conversion setting.

Key changes:

  • Restores temperature unit detection logic by reading the TEMP_UNIT_CONVERT dpcode and applying it to temperature wrappers with empty unit fields
  • Updates test fixture handling to avoid double JSON encoding when values are already strings
  • Adds comprehensive test coverage for a device using TEMP_UNIT_CONVERT functionality

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
homeassistant/components/tuya/climate.py Adds logic to check for TEMP_UNIT_CONVERT dpcode and populate empty temperature unit fields with the device's current unit setting
tests/components/tuya/conftest.py Updates device fixture creation to handle pre-stringified JSON values, preventing double encoding
tests/components/tuya/fixtures/wk_B0eP8qYAdpUo4yR9.json Adds test fixture for ITC-308-WIFI thermostat device with TEMP_UNIT_CONVERT support and empty unit fields
tests/components/tuya/snapshots/test_climate.ambr Adds expected test snapshots for the new fixture in both metric and US customary unit systems

@zweckj zweckj merged commit 4805b33 into dev Dec 4, 2025
36 checks passed
@zweckj zweckj deleted the epenet-20251204-1542 branch December 4, 2025 15:17
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tuya error Entity climate.itc_308_wifi_thermostat does not support action climate.set_temperature

4 participants