Skip to content

Conversation

@Lash-L
Copy link
Contributor

@Lash-L Lash-L commented Dec 4, 2025

Breaking change

Proposed change

Fixes a few bugs in the library implementation. Should be included in next patch.

Should improve reliability
Changes: Python-roborock/python-roborock@v3.9.3...v3.10.0

Changelog: https://github.com/Python-roborock/python-roborock/blob/main/CHANGELOG.md#v3100-2025-12-04

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Dec 4, 2025

Hey there @allenporter, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the python-roborock dependency from version 3.9.3 to 3.10.0 to fix bugs in the library implementation. The update is intended to be included in the next patch release and addresses issue #157946.

Key changes:

  • Bumps python-roborock dependency from 3.9.3 to 3.10.0 across all requirement files and the manifest

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
requirements_all.txt Updates python-roborock version from 3.9.3 to 3.10.0
requirements_test_all.txt Updates python-roborock test requirement from 3.9.3 to 3.10.0
homeassistant/components/roborock/manifest.json Updates python-roborock requirement in manifest from 3.9.3 to 3.10.0

Review Summary: This is a straightforward dependency version bump with no issues found. The version update is consistent across all three files, and the changes align with the PR's purpose of fixing bugs in the python-roborock library.

@zweckj zweckj merged commit 710b7c2 into home-assistant:dev Dec 4, 2025
73 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Roborock error: Failed setup, will retry: Failed to get Roborock home data - Uncaught error in callback 'find_response', invalid start byte

5 participants