-
-
Notifications
You must be signed in to change notification settings - Fork 36.3k
Bump evohome-async to 1.0.6 #158005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump evohome-async to 1.0.6 #158005
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds test fixtures and snapshots for issue #157546, which involves testing the Evohome integration's handling of 8-digit system_id values. The test data is based on the h139906 test case structure but modified to use system_id "10090510" (8 digits) instead of "3454856" (7 digits), verifying that the integration correctly handles longer system identifiers.
Key changes:
- Added new test case "h157546" to TEST_INSTALLS tuple
- Created comprehensive test fixtures including user locations, system status, and zone schedules for the new test case
- Updated test snapshots to include expected states for the h157546 test scenario
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/components/evohome/const.py | Adds "h157546" to the TEST_INSTALLS tuple with a descriptive comment indicating it tests 8-digit system_id values |
| tests/components/evohome/fixtures/h157546/user_locations.json | New fixture defining location configuration with an 8-digit systemId "10090510" and two heating zones |
| tests/components/evohome/fixtures/h157546/status_2727366.json | New fixture providing system status data corresponding to the user_locations, including zone temperatures and fault information |
| tests/components/evohome/fixtures/h157546/schedule_3454855.json | New fixture with weekly schedule data for zone 3454855 (Thermostat 2) |
| tests/components/evohome/fixtures/h157546/schedule_3454854.json | New fixture with empty schedule data for zone 3454854 (Thermostat) |
| tests/components/evohome/snapshots/test_init.ambr | Adds snapshot entry for h157546 test case verifying expected service registrations |
| tests/components/evohome/snapshots/test_climate.ambr | Adds multiple snapshot entries for h157546 test scenarios including entity states and HVAC mode operations |
|
Would it make sense to add all the tests in a separate (follow-up) PR? |
edenhaus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zxdavb 👍
Proposed change
Fixes #157546 by updating the integration's client library, see: zxdavb/evohome-async@1.0.5...1.0.6.
Also adds test fixtures to ensure that this fix is valid (these tests would fail with v1.0.5 of the client).
Note the AI description is dated (it was generated before the latest commits to this PR):
Type of change
Additional information
The core change in the client library is from:
... to:
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: