Skip to content

Conversation

@zxdavb
Copy link
Contributor

@zxdavb zxdavb commented Dec 4, 2025

Proposed change

Fixes #157546 by updating the integration's client library, see: zxdavb/evohome-async@1.0.5...1.0.6.

Also adds test fixtures to ensure that this fix is valid (these tests would fail with v1.0.5 of the client).

Note the AI description is dated (it was generated before the latest commits to this PR):

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

The core change in the client library is from:

if not isinstance(data_, str):
    return data_

... to:

REGEX_DATETIME = r"^\d{4}-\d{2}-\d{2}[T ]\d{2}:\d{2}:\d{2}"

if not isinstance(data_, str) or not re.match(REGEX_DATETIME, data_):
    return data_

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings December 4, 2025 19:48
@zxdavb zxdavb changed the title add the test for Evohome fails with: system_id='...' not known WIP: add the test for Evohome fails with: system_id='...' not known Dec 4, 2025
@zxdavb zxdavb marked this pull request as draft December 4, 2025 19:50
@zxdavb zxdavb changed the title WIP: add the test for Evohome fails with: system_id='...' not known Bump evohome-async to 1.0.6 Dec 4, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds test fixtures and snapshots for issue #157546, which involves testing the Evohome integration's handling of 8-digit system_id values. The test data is based on the h139906 test case structure but modified to use system_id "10090510" (8 digits) instead of "3454856" (7 digits), verifying that the integration correctly handles longer system identifiers.

Key changes:

  • Added new test case "h157546" to TEST_INSTALLS tuple
  • Created comprehensive test fixtures including user locations, system status, and zone schedules for the new test case
  • Updated test snapshots to include expected states for the h157546 test scenario

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/components/evohome/const.py Adds "h157546" to the TEST_INSTALLS tuple with a descriptive comment indicating it tests 8-digit system_id values
tests/components/evohome/fixtures/h157546/user_locations.json New fixture defining location configuration with an 8-digit systemId "10090510" and two heating zones
tests/components/evohome/fixtures/h157546/status_2727366.json New fixture providing system status data corresponding to the user_locations, including zone temperatures and fault information
tests/components/evohome/fixtures/h157546/schedule_3454855.json New fixture with weekly schedule data for zone 3454855 (Thermostat 2)
tests/components/evohome/fixtures/h157546/schedule_3454854.json New fixture with empty schedule data for zone 3454854 (Thermostat)
tests/components/evohome/snapshots/test_init.ambr Adds snapshot entry for h157546 test case verifying expected service registrations
tests/components/evohome/snapshots/test_climate.ambr Adds multiple snapshot entries for h157546 test scenarios including entity states and HVAC mode operations

@zxdavb zxdavb added the bugfix label Dec 4, 2025
@zxdavb zxdavb added this to the 2025.12.1 milestone Dec 4, 2025
@zxdavb zxdavb self-assigned this Dec 4, 2025
@zxdavb zxdavb marked this pull request as ready for review December 4, 2025 21:45
@epenet
Copy link
Contributor

epenet commented Dec 5, 2025

Would it make sense to add all the tests in a separate (follow-up) PR?
The tests don't actually need to go in a patch release - only the dependency bump.

Copy link
Member

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zxdavb 👍

@edenhaus edenhaus merged commit f189e3b into home-assistant:dev Dec 5, 2025
67 checks passed
@zxdavb zxdavb deleted the evo_bugfix branch December 5, 2025 14:48
frenck pushed a commit that referenced this pull request Dec 5, 2025
@frenck frenck mentioned this pull request Dec 5, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Evohome fails with: system_id='...' not known

5 participants