Skip to content

Conversation

@ptarjan
Copy link
Contributor

@ptarjan ptarjan commented Dec 4, 2025

Breaking change

Proposed change

The doorbird integration was generating duplicate unique IDs for event entities when multiple HTTP favorites had the same event name. This caused errors like "Platform doorbird does not generate unique IDs. ID xxx_doorbell_doorbell already exists".

The fix adds deduplication logic in _async_get_event_config() to track which event names have already been processed and skip duplicate favorites with the same event name.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • I have followed the [perfect PR recommendations][perfect-pr]
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

To help with the load of incoming pull requests:

  • No open PRs for this issue

@home-assistant
Copy link

home-assistant bot commented Dec 4, 2025

Hey there @oblogic7, @bdraco, @flacjacket, mind taking a look at this pull request as it has been labeled with an integration (doorbird) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of doorbird can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign doorbird Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@ptarjan ptarjan force-pushed the claude/fix-issue-134353-01NRLte7we8TgRwhXWBKvgni branch from a7802c3 to bd4ea54 Compare December 4, 2025 22:41
@ptarjan ptarjan force-pushed the claude/fix-issue-134353-01NRLte7we8TgRwhXWBKvgni branch 3 times, most recently from 34d6856 to df7ff34 Compare December 5, 2025 14:51
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my doorbird. All good

@bdraco bdraco added this to the 2025.12.1 milestone Dec 5, 2025
@bdraco
Copy link
Member

bdraco commented Dec 5, 2025

Thanks @ptarjan

@ptarjan
Copy link
Contributor Author

ptarjan commented Dec 5, 2025

Yay! Thanks so much for the prompt review and all the fixes you wrote there. Are you the one to merge or what is the procedure?

ptarjan and others added 3 commits December 5, 2025 09:04
The doorbird integration was generating duplicate unique IDs for event
entities when multiple HTTP favorites had the same event name. This
caused errors like "Platform doorbird does not generate unique IDs. ID
xxx_doorbell_doorbell already exists".

The fix filters HTTP favorites by checking if their URL matches the
current Home Assistant instance URL. This filters out stale favorites
from other HA instances or old configurations that weren't cleaned up.

Fixes home-assistant#134353
@ptarjan ptarjan force-pushed the claude/fix-issue-134353-01NRLte7we8TgRwhXWBKvgni branch from ea555ae to 3b3eb7a Compare December 5, 2025 16:04
@bdraco bdraco merged commit 35e6f50 into home-assistant:dev Dec 5, 2025
36 checks passed
frenck pushed a commit that referenced this pull request Dec 5, 2025
@frenck frenck mentioned this pull request Dec 5, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2025
@ptarjan ptarjan deleted the claude/fix-issue-134353-01NRLte7we8TgRwhXWBKvgni branch December 8, 2025 15:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Platform doorbird does not generate unique IDs

3 participants