-
-
Notifications
You must be signed in to change notification settings - Fork 36.3k
Fix doorbird duplicate unique ID generation #158013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix doorbird duplicate unique ID generation #158013
Conversation
|
Hey there @oblogic7, @bdraco, @flacjacket, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
a7802c3 to
bd4ea54
Compare
34d6856 to
df7ff34
Compare
bdraco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on my doorbird. All good
|
Thanks @ptarjan |
|
Yay! Thanks so much for the prompt review and all the fixes you wrote there. Are you the one to merge or what is the procedure? |
The doorbird integration was generating duplicate unique IDs for event entities when multiple HTTP favorites had the same event name. This caused errors like "Platform doorbird does not generate unique IDs. ID xxx_doorbell_doorbell already exists". The fix filters HTTP favorites by checking if their URL matches the current Home Assistant instance URL. This filters out stale favorites from other HA instances or old configurations that weren't cleaned up. Fixes home-assistant#134353
ea555ae to
3b3eb7a
Compare
Co-authored-by: J. Nick Koston <[email protected]>
Breaking change
Proposed change
The doorbird integration was generating duplicate unique IDs for event entities when multiple HTTP favorites had the same event name. This caused errors like "Platform doorbird does not generate unique IDs. ID xxx_doorbell_doorbell already exists".
The fix adds deduplication logic in
_async_get_event_config()to track which event names have already been processed and skip duplicate favorites with the same event name.Type of change
Additional information
Checklist
ruff format homeassistant tests)To help with the load of incoming pull requests: