-
-
Notifications
You must be signed in to change notification settings - Fork 36.3k
Bump python-roborock to 3.10.2 #158020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump python-roborock to 3.10.2 #158020
Conversation
|
Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades the python-roborock library from version 3.10.0 to 3.10.1 to fix a bug related to unique IDs and cached information handling. The issue stemmed from data round-tripping from JSON where dictionary keys were incorrectly treated as strings instead of integers. The fix is entirely within the upgraded library.
Key changes:
- Bump python-roborock dependency to version 3.10.1
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| requirements_test_all.txt | Update python-roborock test dependency to 3.10.1 |
| requirements_all.txt | Update python-roborock dependency to 3.10.1 |
| homeassistant/components/roborock/manifest.json | Update python-roborock requirement to 3.10.1 in manifest |
|
Bumped from 3.10.1 to 3.10.2 and updated PR description and title |
|
test failures unrelated |
Proposed change
Bump python-roborock to 3.10.2
Release notes: https://github.com/Python-roborock/python-roborock/releases/tag/v3.10.2
Changes: Python-roborock/python-roborock@v3.10.0...v3.10.2
This addresses an issue with unique ids and cached information that were created incorrectly based on data round tripping from json dict key as a string instead of an int. Future PRs will cleanup and migrate unique ids for images to have a better key. (There are older/existing unique id issues to clean up too)
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: