Skip to content

Conversation

@allenporter
Copy link
Contributor

@allenporter allenporter commented Dec 5, 2025

Proposed change

Bump python-roborock to 3.10.2
Release notes: https://github.com/Python-roborock/python-roborock/releases/tag/v3.10.2
Changes: Python-roborock/python-roborock@v3.10.0...v3.10.2

This addresses an issue with unique ids and cached information that were created incorrectly based on data round tripping from json dict key as a string instead of an int. Future PRs will cleanup and migrate unique ids for images to have a better key. (There are older/existing unique id issues to clean up too)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@allenporter allenporter added this to the 2025.12.1 milestone Dec 5, 2025
Copilot AI review requested due to automatic review settings December 5, 2025 04:11
@home-assistant
Copy link

home-assistant bot commented Dec 5, 2025

Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the python-roborock library from version 3.10.0 to 3.10.1 to fix a bug related to unique IDs and cached information handling. The issue stemmed from data round-tripping from JSON where dictionary keys were incorrectly treated as strings instead of integers. The fix is entirely within the upgraded library.

Key changes:

  • Bump python-roborock dependency to version 3.10.1

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
requirements_test_all.txt Update python-roborock test dependency to 3.10.1
requirements_all.txt Update python-roborock dependency to 3.10.1
homeassistant/components/roborock/manifest.json Update python-roborock requirement to 3.10.1 in manifest

@allenporter allenporter mentioned this pull request Dec 5, 2025
21 tasks
@allenporter allenporter marked this pull request as draft December 5, 2025 06:22
@allenporter allenporter changed the title Bump python-roborock to 3.10.1 Bump python-roborock to 3.10.2 Dec 5, 2025
@allenporter allenporter marked this pull request as ready for review December 5, 2025 06:23
@allenporter
Copy link
Contributor Author

Bumped from 3.10.1 to 3.10.2 and updated PR description and title

@zweckj
Copy link
Member

zweckj commented Dec 5, 2025

test failures unrelated

@zweckj zweckj merged commit 73f2316 into home-assistant:dev Dec 5, 2025
61 of 63 checks passed
frenck pushed a commit that referenced this pull request Dec 5, 2025
@frenck frenck mentioned this pull request Dec 5, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Platform roborock does not generate unique IDs

4 participants