Skip to content

Conversation

@TheJulianJES
Copy link
Member

@TheJulianJES TheJulianJES commented Dec 5, 2025

Proposed change

This changes the ZHA string for the "incorrect firmware installed" repair to be more broad and also cover the state of the adapter being stuck in the bootloader or just having Thread firmware installed.

Specifically "multiprotocol" firmware is mentioned now, which is rarely the case.

Background

Currently, there's a (rare) issue where ZBT can get stuck in the bootloader after a firmware update.
Due to recent changes in the flasher library, we currently no longer try to get the adapter out of that state.

Goal

The goal of this changed string is just to avoid user confusion if they get stuck in this state after installing a firmware update. Users shouldn't need to be confused about multiprotocol firmware suddenly being installed, or the update having installed some wrong firmware in general, so that's why this is changed to a more relaxed "Incorrect state" error that also encompasses the "stuck in bootloader" state.

Future

In the future, we should have both (1) a fix for the device getting stuck in the bootloader and likely (2) a method to get the device out of the bootloader if possible (but only if we don't risk bricking the device if there's incorrect firmware installed when there's bootloader triggers).

As soon as these underlying issues are fixed (in another major HA release), this string will be updated again to just show "Incorrect firmware installed", but avoid the explicit mention of multiprotocol.

Images of updated repair dialogs

HA Connect series adapter in incorrect state Third-party adapter in incorrect state
image image

(Not sure why the font is a bit weird on my instance right now. Maybe recent Core/Frontend changes, as I'm also seeing this for other repairs. Not a result of the changes from this PR though.)

Alternatives

Alternatively, I've also thought about adding another repair/translation that's just shown if the device is stuck in the bootloader. Then, we'd have one variant for incorrect firmware and one for the adapter being in the bootloader.
I think adding that might be a bit too much for a patch release, so I've opted for this variant, for now.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Dec 5, 2025

Hey there @dmulcahey, @Adminiuga, @puddly, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zha can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zha Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates ZHA repair strings to better handle incorrect adapter states beyond just multiprotocol firmware. The updated messaging covers scenarios where adapters may be stuck in the bootloader or have Thread firmware installed, providing clearer guidance for users experiencing these issues.

Key Changes:

  • Broadened error description from "multiprotocol firmware detected" to "incorrect state" to cover bootloader issues
  • Updated user guidance to include unplugging the adapter as a first troubleshooting step
  • Changed titles from "multiprotocol firmware detected" to "adapter in incorrect state"

Copy link
Contributor

@NoRi2909 NoRi2909 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As "multiprotocol" is not a name and will be translated, it should not be capitalized.

Co-authored-by: Norbert Rittel <[email protected]>
@frenck frenck merged commit 2280d77 into home-assistant:dev Dec 5, 2025
36 checks passed
frenck pushed a commit that referenced this pull request Dec 5, 2025
@frenck frenck mentioned this pull request Dec 5, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants