-
-
Notifications
You must be signed in to change notification settings - Fork 36.3k
Be more specific about winter mode in the description #158230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey there @home-assistant/frontend, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds an important clarification to the winter mode feature description, informing users that the feature requires animations to be enabled in their device accessibility settings. This is a helpful user-facing improvement that prevents confusion when users enable the feature but don't see snowflakes due to their accessibility settings.
Key Changes
- Enhanced the winter mode description with accessibility setting requirements
- Added clear explanation that animations must be enabled for the feature to work
Co-authored-by: Norbert Rittel <[email protected]>
Co-authored-by: Norbert Rittel <[email protected]>
Proposed change
Add precision about winter mode in the description : If you have animations disabled in your device accessibility settings, this feature will not work.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: