Skip to content

Conversation

@piitaya
Copy link
Member

@piitaya piitaya commented Dec 8, 2025

Proposed change

Add precision about winter mode in the description : If you have animations disabled in your device accessibility settings, this feature will not work.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@piitaya piitaya added this to the 2025.12.2 milestone Dec 8, 2025
Copilot AI review requested due to automatic review settings December 8, 2025 10:49
@home-assistant
Copy link

home-assistant bot commented Dec 8, 2025

Hey there @home-assistant/frontend, mind taking a look at this pull request as it has been labeled with an integration (frontend) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of frontend can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign frontend Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an important clarification to the winter mode feature description, informing users that the feature requires animations to be enabled in their device accessibility settings. This is a helpful user-facing improvement that prevents confusion when users enable the feature but don't see snowflakes due to their accessibility settings.

Key Changes

  • Enhanced the winter mode description with accessibility setting requirements
  • Added clear explanation that animations must be enabled for the feature to work

Co-authored-by: Norbert Rittel <[email protected]>
@joostlek joostlek changed the title Add precision about winter mode in the description Be more specific about winter mode in the description Dec 8, 2025
@joostlek joostlek merged commit eeb2b2f into dev Dec 8, 2025
61 of 62 checks passed
@joostlek joostlek deleted the winter_mode_description_reduced_motion branch December 8, 2025 14:28
frenck pushed a commit that referenced this pull request Dec 8, 2025
@frenck frenck mentioned this pull request Dec 8, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants